Re: [libcpp,lto,fortran PATCH] Fix linemap_add use and remove unnecessary kludge

2011-08-28 Thread Richard Guenther
On Sat, Aug 27, 2011 at 9:04 PM, Dodji Seketeli wrote: > Hello Richard, > > Richard Guenther writes: > >> In the LTO FE the two linemap_add calls were to advance the location >> counter to cover the builtin special locations.  You exchange these >> with only one - that doesn't look correct withou

Re: [libcpp,lto,fortran PATCH] Fix linemap_add use and remove unnecessary kludge

2011-08-27 Thread Dodji Seketeli
Hello Richard, Richard Guenther writes: > In the LTO FE the two linemap_add calls were to advance the location > counter to cover the builtin special locations. You exchange these > with only one - that doesn't look correct without more explanation. It seems to me that you don't need to worry

Re: [libcpp,lto,fortran PATCH] Fix linemap_add use and remove unnecessary kludge

2011-08-27 Thread Richard Guenther
On Sat, Aug 27, 2011 at 12:18 PM, Dodji Seketeli wrote: > Tom Tromey writes: > >> Dodji>        * line-map.c (linemap_add): Assert that reason must not be >> Dodji>        LC_RENAME when called for the first time on a "main input >> file". >> >> This is ok.  I can't approve the rest but it seems

Re: [libcpp,lto,fortran PATCH] Fix linemap_add use and remove unnecessary kludge

2011-08-27 Thread Dodji Seketeli
Tom Tromey writes: > Dodji>* line-map.c (linemap_add): Assert that reason must not be > Dodji>LC_RENAME when called for the first time on a "main input file". > > This is ok. I can't approve the rest but it seems reasonable. Tobias Burnus writes: > The Fortran part is OK. Than

Re: [libcpp,lto,fortran PATCH] Fix linemap_add use and remove unnecessary kludge

2011-08-24 Thread Tobias Burnus
(fortran@ readers: The full patch is at http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01927.html ) On 08/23/2011 08:43 PM, Dodji Seketeli wrote: OK for trunk? The Fortran part is OK. Thanks for the patch! Tobias gcc/fortran/ * scanner.c (load_file): Don't abuse LC_RENAME reason whi

Re: [libcpp,lto,fortran PATCH] Fix linemap_add use and remove unnecessary kludge

2011-08-24 Thread Tom Tromey
> "Dodji" == Dodji Seketeli writes: Dodji> * line-map.c (linemap_add): Assert that reason must not be Dodji> LC_RENAME when called for the first time on a "main input file". This is ok. I can't approve the rest but it seems reasonable. Tom

[libcpp,lto,fortran PATCH] Fix linemap_add use and remove unnecessary kludge

2011-08-23 Thread Dodji Seketeli
Hello, There are a couple of places in the compiler that need to create line maps directly by calling linemap_add. The problem is, sometimes we wrongly do so by passing LC_RENAME as the reason argument even when creating the first map of a given file. But then linemap_add has some code to change