Re: [hsa merge 09/10] Majority of the HSA back-end

2016-01-18 Thread Jakub Jelinek
Hi! PDP endian is gcc_assert (!BYTES_BIG_ENDIAN); gcc_assert (WORDS_BIG_ENDIAN); and 16-bit words, thus within uint16_t it is little endian, and the 16-bit words are ordered in larger units in big endian order. > +#else > + val = ((val & 0xff00ff00) >> 8) | ((val & 0xff00ff) << 8);

Re: [hsa merge 09/10] Majority of the HSA back-end

2016-01-18 Thread Martin Jambor
Hi, On Sat, Jan 16, 2016 at 09:58:51AM +0100, Jakub Jelinek wrote: > On Sat, Jan 16, 2016 at 12:49:12AM +0100, Martin Jambor wrote: > > bootstrapping on i686-linux revealed the need for the following simple > > patch. I've run into two types of compilation errors on > > powerpc-ibm-aix (no htolen

Re: [hsa merge 09/10] Majority of the HSA back-end

2016-01-16 Thread Jakub Jelinek
On Sat, Jan 16, 2016 at 09:58:51AM +0100, Jakub Jelinek wrote: > IMHO you'd be best to write your own helpers for conversion to little > endian (and back). > gcc configure already has AC_C_BIGENDIAN (dunno how it handles pdp endian > host though, so not sure if it is safe to rely on that), for rece

Re: [hsa merge 09/10] Majority of the HSA back-end

2016-01-16 Thread Jakub Jelinek
On Sat, Jan 16, 2016 at 12:49:12AM +0100, Martin Jambor wrote: > bootstrapping on i686-linux revealed the need for the following simple > patch. I've run into two types of compilation errors on > powerpc-ibm-aix (no htolenn functions and ASM_GENERATE_INTERNAL_LABEL > somehow expanding to undeclare

Re: [hsa merge 09/10] Majority of the HSA back-end

2016-01-15 Thread Martin Jambor
Hi, bootstrapping on i686-linux revealed the need for the following simple patch. I've run into two types of compilation errors on powerpc-ibm-aix (no htolenn functions and ASM_GENERATE_INTERNAL_LABEL somehow expanding to undeclared rs6000_xcoff_strip_dollar). I plan to workaround them quickly b

Re: [hsa merge 09/10] Majority of the HSA back-end

2016-01-15 Thread Jakub Jelinek
On Fri, Jan 15, 2016 at 04:08:14PM +0100, Martin Jambor wrote: > We don't error, apart from issuing a warning we basically ignore them. > I believe we can do it even in the long term and that it is in fact > useful because the standard says that the "effect" if these routines > is "unspecified" if

Re: [hsa merge 09/10] Majority of the HSA back-end

2016-01-15 Thread Martin Jambor
Hi, thanks Jakub. Below you'll find a patch, which is mostly work of Martin Liska, that should address all the review comments. We have then also went over the "XXX" marks (my bad that I forgot that Michael uses this mark), removed half of them and turned the rest into TODOs. Let me just quickl

Re: [hsa merge 09/10] Majority of the HSA back-end

2016-01-14 Thread Jakub Jelinek
On Wed, Jan 13, 2016 at 06:39:34PM +0100, Martin Jambor wrote: > +struct function_linkage_pair > +{ > + function_linkage_pair (tree decl, unsigned int off): I would have expected a space before :, or better yet on the next line: function_linkage_pair (tree decl, unsigned int off) : function