Re: [hsa 1/10] Configury changes and new options

2015-12-11 Thread Jakub Jelinek
On Thu, Dec 10, 2015 at 06:52:07PM +0100, Martin Jambor wrote: > Good catch. I have modified this code so that it never leaves any > holes in offload_names[i]. > > > names[i] is null-terminated, so it looks like you're deliberately > > allowing anything that starts with "hsa" here, but: > > Righ

Re: [hsa 1/10] Configury changes and new options

2015-12-10 Thread Martin Jambor
Hi, On Mon, Dec 07, 2015 at 12:19:08PM +0100, Martin Jambor wrote: > Hi, > > this patch contains changes to the configuration mechanism and offload > bits, so that users can build compilers with HSA support. when writing up how to build an HSA-enabled GCC for the wiki page, and checking the proc

Re: [hsa 1/10] Configury changes and new options

2015-12-10 Thread Martin Jambor
Hi, On Tue, Dec 08, 2015 at 10:43:15PM +, Richard Sandiford wrote: > [Sorry for the low-quality review, was just reading out of interest...] > > Martin Jambor writes: > > +If you configure GCC with HSA offloading but do not have the HSA > > +run-time library installed in a standard location

Re: [hsa 1/10] Configury changes and new options

2015-12-08 Thread Richard Sandiford
[Sorry for the low-quality review, was just reading out of interest...] Martin Jambor writes: > +If you configure GCC with HSA offloading but do not have the HSA > +run-time library installed in a standard location then you can > +explicitely specify the directory where they are installed. The

[hsa 1/10] Configury changes and new options

2015-12-07 Thread Martin Jambor
Hi, this patch contains changes to the configuration mechanism and offload bits, so that users can build compilers with HSA support. It plays nicely with other accelerators despite using an altogether different implementation approach. I have also added to it definitions of the new options and pa