Re: [google gcc-4_9] Fix bad LIPO profile produced by gcov-tool

2015-12-01 Thread Xinliang David Li
So that field was never inited/used before? Also saved_compressed_len = (unsigned long) gcov_read_unsigned (); should use unsigned not unsigned long type. On Tue, Dec 1, 2015 at 4:53 PM, Rong Xu wrote: > This is only needed for gcov-tool as we need to rewrite the > moduel-info to the profile (t

Re: [google gcc-4_9] Fix bad LIPO profile produced by gcov-tool

2015-12-01 Thread Rong Xu
This is only needed for gcov-tool as we need to rewrite the moduel-info to the profile (this is only used in decompress) The transitional compiler path does not need it because the string is already decompressed. It only needs to use the strings. gcov-dump in theory does not need it either if it

[google gcc-4_9] Fix bad LIPO profile produced by gcov-tool

2015-12-01 Thread Rong Xu
Hi, This patch fixes the issue when using gcov-tool to merge LIPO profiles after we compressing the module infomration . We should not decompress the string as the compressed string should be written directly to the profile later. Tested with some LIPO profiles. Thanks, -Rong 2015-12-01 Rong Xu