Re: [google gcc-4_8] unify int and fp scaling in gcov-tool

2014-02-10 Thread Rong Xu
Yes. They were the bug I mentioned. This patch fixed that. -Rong On Mon, Feb 10, 2014 at 10:40 AM, Teresa Johnson wrote: > Looks good to me. > > A couple questions: > >> static void >> -__gcov_scale_icall_topn (gcov_type *counters, unsigned n_counters, double f) >> +__gcov_icall_topn_op (gcov_t

Re: [google gcc-4_8] unify int and fp scaling in gcov-tool

2014-02-10 Thread Teresa Johnson
Looks good to me. A couple questions: > static void > -__gcov_scale_icall_topn (gcov_type *counters, unsigned n_counters, double f) > +__gcov_icall_topn_op (gcov_type *counters, unsigned n_counters, > + counter_op_fn fn, void *data1, void *data2) > { >unsigned i; > > @@

[google gcc-4_8] unify int and fp scaling in gcov-tool

2014-02-04 Thread Rong Xu
Hi, The attached patch uses a callback function to unify the integer and floating-point scaling in gcov-tool. (Also fix a bug in fp scaling of ic and dc counters in earlier code). Tested with spec2006 profiles. OK for checking in? Thanks, -Rong 2014-02-04 Rong Xu * gcc/gcov-tool.c