Re: [google gcc-4_7] new module grouping method (issue 7393058)

2013-02-26 Thread xur
https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c File libgcc/dyn-ipa.c (right): https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c#newcode1212 libgcc/dyn-ipa.c:1212: mod_id = get_module_id_from_func_glob_uid (node->guid) - 1; Send the wrong patch. Actually. This s

Re: [google gcc-4_7] new module grouping method (issue 7393058)

2013-02-26 Thread davidxl
https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c File libgcc/dyn-ipa.c (right): https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c#newcode235 libgcc/dyn-ipa.c:235: /* Return module_id. FUNC_GUID is the global unique id. */ Add a comment here that the returned val

Re: [google gcc-4_7] new module grouping method (issue 7393058)

2013-02-26 Thread Xinliang David Li
Can you upload the new patch set? David On Tue, Feb 26, 2013 at 1:50 PM, wrote: > > https://codereview.appspot.com/7393058/diff/1/libgcc/dyn-ipa.c > File libgcc/dyn-ipa.c (right): > > https://codereview.appspot.com/7393058/diff/1/libgcc/dyn-ipa.c#newcode77 > libgcc/dyn-ipa.c:77: /* Used by new

Re: [google gcc-4_7] new module grouping method (issue 7393058)

2013-02-26 Thread xur
https://codereview.appspot.com/7393058/diff/1/libgcc/dyn-ipa.c File libgcc/dyn-ipa.c (right): https://codereview.appspot.com/7393058/diff/1/libgcc/dyn-ipa.c#newcode77 libgcc/dyn-ipa.c:77: /* Used by new algo. This dyn_pointer_set only On 2013/02/26 00:49:17, davidxl wrote: algo --> algorithm.

Re: [google gcc-4_7] new module grouping method (issue 7393058)

2013-02-25 Thread davidxl
The coverage.c related patch is not uploaded properly. Will be reviewed seperately. David https://codereview.appspot.com/7393058/diff/1/gcc/gcov-dump.c File gcc/gcov-dump.c (right): https://codereview.appspot.com/7393058/diff/1/gcc/gcov-dump.c#newcode581 gcc/gcov-dump.c:581: const char *primar