Re: [google] libgcov workaround for weak reference issue (issue 6276043)

2012-06-01 Thread Xinliang David Li
ok. thanks, David On Fri, Jun 1, 2012 at 2:26 PM, Teresa Johnson wrote: > Renamed to __gcov_dummy_ref1 and __gcov_dummy_ref2. I'd prefer that > approach for now to keep the differences with trunk to a minimum. > > Thanks, > Teresa > > On Fri, Jun 1, 2012 at 2:18 PM,   wrote: >> Ok with better n

Re: [google] libgcov workaround for weak reference issue (issue 6276043)

2012-06-01 Thread Teresa Johnson
Renamed to __gcov_dummy_ref1 and __gcov_dummy_ref2. I'd prefer that approach for now to keep the differences with trunk to a minimum. Thanks, Teresa On Fri, Jun 1, 2012 at 2:18 PM, wrote: > Ok with better naming for the dummy function such as > '__gcov_dummy_ref1'. Another choice is to let __gc

Re: [google] libgcov workaround for weak reference issue (issue 6276043)

2012-06-01 Thread davidxl
Ok with better naming for the dummy function such as '__gcov_dummy_ref1'. Another choice is to let __gcov_flush calls __gcov_dump + __gcov_reset -- but the dump_completed state needs to be saved and restored. David http://codereview.appspot.com/6276043/