Re: [gomp4.1] fix more scheduling inconsistencies and add verification routines

2015-10-09 Thread Jakub Jelinek
On Fri, Oct 09, 2015 at 09:38:40AM -0700, Aldy Hernandez wrote: > As per our IRC discussion. > > I am conditionally compiling the verification code because you mentioned > that the GPGPUs may not having a working printf. Both that and code size being important there. > Also, I removed the code c

Re: [gomp4.1] fix more scheduling inconsistencies and add verification routines

2015-10-09 Thread Aldy Hernandez
As per our IRC discussion. I am conditionally compiling the verification code because you mentioned that the GPGPUs may not having a working printf. Also, I removed the code caching the workgroup since it may contain the incorrect workgroup as I had suggested. Now instead we look in child_t

Re: [gomp4.1] fix more scheduling inconsistencies and add verification routines

2015-10-04 Thread Aldy Hernandez
On 10/04/2015 10:26 AM, Aldy Hernandez wrote: However magically this happened before :), my attached changes to gomp_task_run_pre() will move this task to the end of the queue such that the WAITING tasks are first. FWIW, thinking about this some more, I suppose setting a task to GOMP_TASK_TIE

[gomp4.1] fix more scheduling inconsistencies and add verification routines

2015-10-04 Thread Aldy Hernandez
Jakub, this is the inconsistency you pointed out while we were analyzing the scheduling circular lists. The problem in gomp_task_run_pre() is that, upon setting an upcoming running task to TIED, we may leave either the sibling or taskgroup queues in an indeterminate state. We may have upcomin