Re: [gomp4.1] C++ iterators with #omp ordered depend(sink:)

2015-07-16 Thread Jakub Jelinek
On Thu, Jul 16, 2015 at 07:57:56AM -0700, Aldy Hernandez wrote: > @@ -13828,6 +13828,14 @@ tsubst_omp_for_iterator (tree t, int i, tree declv, > tree initv, > >init = TREE_VEC_ELT (OMP_FOR_INIT (t), i); >gcc_assert (TREE_CODE (init) == MODIFY_EXPR); > + > + if (orig_declv && OMP_FOR_ORI

Re: [gomp4.1] C++ iterators with #omp ordered depend(sink:)

2015-07-16 Thread Aldy Hernandez
On 07/16/2015 12:06 AM, Jakub Jelinek wrote: Hi! CCing Jason on a tsubst issue below. On Wed, Jul 15, 2015 at 06:05:06PM -0700, Aldy Hernandez wrote: As I said on IRC, this looks ugly, but I can see why you wouldn't want the extra word on all loop variants. I've implemented it as requested.

Re: [gomp4.1] C++ iterators with #omp ordered depend(sink:)

2015-07-16 Thread Jakub Jelinek
Hi! CCing Jason on a tsubst issue below. On Wed, Jul 15, 2015 at 06:05:06PM -0700, Aldy Hernandez wrote: > As I said on IRC, this looks ugly, but I can see why you wouldn't want the > extra word on all loop variants. I've implemented it as requested. Thanks. > commit f55eced4ac6b045101a90914a8

Re: [gomp4.1] C++ iterators with #omp ordered depend(sink:)

2015-07-15 Thread Aldy Hernandez
On 07/15/2015 08:21 AM, Jakub Jelinek wrote: On Wed, Jul 15, 2015 at 07:47:12AM -0700, Aldy Hernandez wrote: This fixes the problem with C++ iterators not working as sink() iterator variables. OK for branch? I wonder (though not 100% sure about) if, because we really need the OMP_FOR_ORIG_DEC

Re: [gomp4.1] C++ iterators with #omp ordered depend(sink:)

2015-07-15 Thread Jakub Jelinek
On Wed, Jul 15, 2015 at 07:47:12AM -0700, Aldy Hernandez wrote: > This fixes the problem with C++ iterators not working as sink() iterator > variables. > > OK for branch? I wonder (though not 100% sure about) if, because we really need the OMP_FOR_ORIG_DECLS on OMP_FOR only, no other construct ca

[gomp4.1] C++ iterators with #omp ordered depend(sink:)

2015-07-15 Thread Aldy Hernandez
This fixes the problem with C++ iterators not working as sink() iterator variables. OK for branch? Aldy commit feb44bd0b32a941092441206af9157cb45995d81 Author: Aldy Hernandez Date: Tue Jul 14 19:23:09 2015 -0700 * gimplify.c (gimplify_omp_for): Use OMP_FOR_ORIG_DECLS. * tree