Re: [gomp4] Fix Fortran deviceptr

2015-12-09 Thread James Norris
Cesar, On 12/08/2015 11:10 AM, Cesar Philippidis wrote: On 12/08/2015 08:22 AM, James Norris wrote: 2. It appears that deviceptr code in GOACC_parallel_keyed is mostly identical to GOACC_data_start. Can you put that duplicate code into a function? That would be easier to maintai

Re: [gomp4] Fix Fortran deviceptr

2015-12-08 Thread Cesar Philippidis
On 12/08/2015 08:22 AM, James Norris wrote: >> 2. It appears that deviceptr code in GOACC_parallel_keyed is mostly >> identical to GOACC_data_start. Can you put that duplicate code into >> a function? That would be easier to maintain in the long run. >> > > Fixed. Where? I don't see

Re: [gomp4] Fix Fortran deviceptr

2015-12-08 Thread James Norris
Cesar, On 12/07/2015 09:55 AM, Cesar Philippidis wrote: [snip snip] Two observations: 1. Why is deviceptr so special that gomp_map_vars can't handle it directly? Recall that the deviceptr clause in Fortran presents as two mappings: FORCE_DEVICEPTR and POINTER. The former has the devic

Re: [gomp4] Fix Fortran deviceptr

2015-12-07 Thread Cesar Philippidis
On 12/06/2015 06:52 AM, James Norris wrote: > This patch fixes a some runtime issues when dealing with > the deviceptr clause in Fortran. There were some corner > cases that were not being dealt with correctly, and the > patch resolves these. Also a new set of test cases has > been added. Which c

[gomp4] Fix Fortran deviceptr

2015-12-06 Thread James Norris
Hi, This patch fixes a some runtime issues when dealing with the deviceptr clause in Fortran. There were some corner cases that were not being dealt with correctly, and the patch resolves these. Also a new set of test cases has been added. I've applied this patch to gomp-4_0-branch. Jim diff --