Re: [gomp4] Adjust UNQUE ifn

2015-10-26 Thread Nathan Sidwell
On 10/26/15 07:36, Richard Biener wrote: Looks better now. + { #ifdef HAVE_oacc_fork (etc.) can you use target-insn.def and targetm.have_oacc_fork () instead? I've committed this to gomp4. Will port and update the patches for trunk. nathan 2015-10-26 Nathan Sidwell * inter

Re: [gomp4] Adjust UNQUE ifn

2015-10-26 Thread Nathan Sidwell
On 10/26/15 07:36, Richard Biener wrote: + { #ifdef HAVE_oacc_fork (etc.) can you use target-insn.def and targetm.have_oacc_fork () instead? I can try ... nathan

Re: [gomp4] Adjust UNQUE ifn

2015-10-26 Thread Richard Biener
On Mon, Oct 26, 2015 at 3:26 PM, Nathan Sidwell wrote: > On 10/26/15 02:10, Thomas Schwinge wrote: >> >> Hi Nathan! > > } >> >> >> [...]/source-gcc/gcc/internal-fn.c: In function 'void >> expand_UNIQUE(gcall*)': >> [...]/source-gcc/gcc/internal-fn.c:1982:6: error: variable 'target' >> s

Re: [gomp4] Adjust UNQUE ifn

2015-10-26 Thread Nathan Sidwell
On 10/26/15 02:10, Thomas Schwinge wrote: Hi Nathan! } [...]/source-gcc/gcc/internal-fn.c: In function 'void expand_UNIQUE(gcall*)': [...]/source-gcc/gcc/internal-fn.c:1982:6: error: variable 'target' set but not used [-Werror=unused-but-set-variable] rtx target = const0_rt

Re: [gomp4] Adjust UNQUE ifn

2015-10-26 Thread Thomas Schwinge
Hi Nathan! On Sun, 25 Oct 2015 10:01:55 -0400, Nathan Sidwell wrote: > I've applied this patch to gomp4 branch. It's the reworking of IFN_UNIQUE > suggested by Richard & Jakub. > > 1) IFN_UNIQUE is a ctrl-altering call, and thus ends up at the end of a BB. > 2) tracer only needs to check that

[gomp4] Adjust UNQUE ifn

2015-10-25 Thread Nathan Sidwell
I've applied this patch to gomp4 branch. It's the reworking of IFN_UNIQUE suggested by Richard & Jakub. 1) IFN_UNIQUE is a ctrl-altering call, and thus ends up at the end of a BB. 2) tracer only needs to check that stmt (and it'a already looking at it for other reasons) 3) IFN_UNIQUE is no lo