Re: [gimplefe] reject invalid pass name in startwith

2016-12-20 Thread Richard Biener
On Sun, 18 Dec 2016, Prathamesh Kulkarni wrote: > Hi Richard, > The attached patch attempts to reject invalid pass-name in startwith > and verified gimplefe tests pass with the patch (not sure if bootstrap > is required?) > Does it look OK ? No - get_pass_by_name works on dump file names while th

Re: [gimplefe] reject invalid pass name in startwith

2016-12-19 Thread Joseph Myers
The message passed to error_at should not end in \n; the diagnostics machinery deals with inserting the newline. -- Joseph S. Myers jos...@codesourcery.com

Re: [gimplefe] reject invalid pass name in startwith

2016-12-18 Thread Prathamesh Kulkarni
On 18 December 2016 at 18:02, Jakub Jelinek wrote: > On Sun, Dec 18, 2016 at 05:41:23PM +0530, Prathamesh Kulkarni wrote: >> --- a/gcc/c/gimple-parser.c >> +++ b/gcc/c/gimple-parser.c >> @@ -1046,6 +1046,17 @@ c_parser_gimple_pass_list (c_parser *parser) >>if (! c_parser_require (parser, CPP_C

Re: [gimplefe] reject invalid pass name in startwith

2016-12-18 Thread Jakub Jelinek
On Sun, Dec 18, 2016 at 05:41:23PM +0530, Prathamesh Kulkarni wrote: > --- a/gcc/c/gimple-parser.c > +++ b/gcc/c/gimple-parser.c > @@ -1046,6 +1046,17 @@ c_parser_gimple_pass_list (c_parser *parser) >if (! c_parser_require (parser, CPP_CLOSE_PAREN, "expected %<)%>")) > return NULL; > > +

[gimplefe] reject invalid pass name in startwith

2016-12-18 Thread Prathamesh Kulkarni
Hi Richard, The attached patch attempts to reject invalid pass-name in startwith and verified gimplefe tests pass with the patch (not sure if bootstrap is required?) Does it look OK ? Thanks, Prathamesh 2016-12-18 Prathamesh Kulkarni c/ * gimple-parser.c (c_parser_gimple_pass_list): Re