Re: [fixincludes] Fix signbit on Solaris

2015-02-09 Thread Bruce Korb
On Mon, Feb 9, 2015 at 3:30 AM, Rainer Orth wrote: > That worked fine indeed and is considerably more readable than my > previous version. Excellent! Thank you. > It produced the identical fixincl.x, passed fixincludes make check and > Solaris 10 and 11 bootstraps. > > Ok for mainline now, I g

Re: [fixincludes] Fix signbit on Solaris

2015-02-09 Thread Rainer Orth
Bruce Korb writes: > On 01/29/15 05:38, Rainer Orth wrote: >> So I saw. If all else fails, we can still commit the (ugly/hard to >> read) initial version, otherwise libgo won't build on Solaris before >> some (quite recent) Solaris 11.2 patch, breaking bootstrap. > > Having it work at all seems

Re: [fixincludes] Fix signbit on Solaris

2015-01-30 Thread Bruce Korb
On 01/29/15 05:38, Rainer Orth wrote: So I saw. If all else fails, we can still commit the (ugly/hard to read) initial version, otherwise libgo won't build on Solaris before some (quite recent) Solaris 11.2 patch, breaking bootstrap. Having it work at all seems like a nice feature. I think tha

Re: [fixincludes] Fix signbit on Solaris

2015-01-29 Thread Rainer Orth
Bruce Korb writes: > On 01/28/15 10:15, Bruce Korb wrote: >> On 01/28/15 10:13, Bruce Korb wrote: >>> Hi Rainer, >>> >>> Sorry for the long delay. Anyway: >>> >>> On 01/28/15 06:12, Rainer Orth wrote: >> * In test_text, I had to backslash-escape the trailing \, otherwise they >>were

Re: [fixincludes] Fix signbit on Solaris

2015-01-28 Thread Bruce Korb
On 01/28/15 10:15, Bruce Korb wrote: On 01/28/15 10:13, Bruce Korb wrote: Hi Rainer, Sorry for the long delay. Anyway: On 01/28/15 06:12, Rainer Orth wrote: * In test_text, I had to backslash-escape the trailing \, otherwise they were eaten up. Whether or not I do this makes no differenc

Re: [fixincludes] Fix signbit on Solaris

2015-01-28 Thread Bruce Korb
On 01/28/15 10:13, Bruce Korb wrote: Hi Rainer, Sorry for the long delay. Anyway: On 01/28/15 06:12, Rainer Orth wrote: * In test_text, I had to backslash-escape the trailing \, otherwise they were eaten up. Whether or not I do this makes no difference for the generated fixincl.x, but

Re: [fixincludes] Fix signbit on Solaris

2015-01-28 Thread Bruce Korb
Hi Rainer, Sorry for the long delay. Anyway: On 01/28/15 06:12, Rainer Orth wrote: * In test_text, I had to backslash-escape the trailing \, otherwise they were eaten up. Whether or not I do this makes no difference for the generated fixincl.x, but only with the escaping does make check

Re: [fixincludes] Fix signbit on Solaris

2015-01-28 Thread Rainer Orth
Hi Bruce, this thread is more than half a year old now, but with the GCC 5 release approaching, we should reach some conclusion. > On Tue, Jul 1, 2014 at 4:22 AM, Rainer Orth > wrote: >>> It's not yet in autogen 5.9: I've diffed the fixincl.x generated with my >>> original patch and the amended

Re: [fixincludes] Fix signbit on Solaris

2014-07-01 Thread Bruce Korb
Hi Rainer, On Tue, Jul 1, 2014 at 4:22 AM, Rainer Orth wrote: >> It's not yet in autogen 5.9: I've diffed the fixincl.x generated with my >> original patch and the amended one and those backslashes after the >> leading tab are still there. 5.9 is 7 years old now. However, I just looked up the

Re: [fixincludes] Fix signbit on Solaris

2014-07-01 Thread Rainer Orth
Hi Bruce, >> On 06/26/14 02:18, Rainer Orth wrote: >>> Ok for mainline? >> >> Could you please reformat the c_fix_arg's and test-text to be "here strings" >> a la: >> >> c_fix_arg = <<- _EOS_ >> #undef signbit >> #define signbit(x) (sizeof(x) == sizeof(float) \ >> \

Re: [fixincludes] Fix signbit on Solaris

2014-07-01 Thread Rainer Orth
Hi Bruce, > On 06/26/14 02:18, Rainer Orth wrote: >> Ok for mainline? > > Could you please reformat the c_fix_arg's and test-text to be "here strings" > a la: > > c_fix_arg = <<- _EOS_ > #undef signbit > #define signbit(x) (sizeof(x) == sizeof(float) \ > \

Re: [fixincludes] Fix signbit on Solaris

2014-06-28 Thread Bruce Korb
On 06/26/14 02:18, Rainer Orth wrote: Ok for mainline? Could you please reformat the c_fix_arg's and test-text to be "here strings" a la: c_fix_arg = <<- _EOS_ #undef signbit #define signbit(x) (sizeof(x) == sizeof(float) \ \ ? __buil

[fixincludes] Fix signbit on Solaris

2014-06-26 Thread Rainer Orth
As reported before https://gcc.gnu.org/ml/gcc-patches/2014-06/msg00213.html the Solaris signbit implementation for GNU C in gives warnings with -Wstrict-aliasing, breaking Go bootstrap. The following patch fixes this along the lines of the current solaris_math_8 fix. I've tried to use