Re: [fixincludes, v3] Don't define libstdc++-internal macros in Solaris 10+

2016-11-21 Thread Bruce Korb
I missed the patch because the thread got too long. Also, I trust you after all these years. :) On Mon, Nov 21, 2016 at 1:48 AM, Rainer Orth wrote: > Hi Jonathan, > >>>Ok for mainline now and the backports after some soak time? >> >> Yes, the libstdc++ parts are OK, thanks. > > I assume Bruce is

Re: [fixincludes, v3] Don't define libstdc++-internal macros in Solaris 10+

2016-11-21 Thread Rainer Orth
Hi Jonathan, >>Ok for mainline now and the backports after some soak time? > > Yes, the libstdc++ parts are OK, thanks. I assume Bruce is ok with the change to the hpux11_fabsf fix given that it was suggested by the HP-UX maintainer and fixes fixincludes make check ;-) Rainer -- --

Re: [fixincludes, v3] Don't define libstdc++-internal macros in Solaris 10+

2016-11-18 Thread Jonathan Wakely
On 18/11/16 12:10 +0100, Rainer Orth wrote: The change is OK in principle, but I'd prefer more meaningful names for the macros ... Fine with me: I know close to nothing of C++, so please bear with me ;-) No problem, that's what the rest of us are here to help with :-) I don't mind whether y

Re: [fixincludes, v3] Don't define libstdc++-internal macros in Solaris 10+

2016-11-18 Thread Rainer Orth
Hi Jonathan, > On 03/11/16 15:11 +0100, Rainer Orth wrote: >>Fortunately, this is all easily fixed by wrapping the affected templates >>in a new macro. That's what this patch does. The new libstdc++ >>acinclude.m4 test may well need wording changes in comments etc. and can >>perhaps be shortened

Re: [fixincludes, v3] Don't define libstdc++-internal macros in Solaris 10+

2016-11-17 Thread Jonathan Wakely
On 03/11/16 15:11 +0100, Rainer Orth wrote: Fortunately, this is all easily fixed by wrapping the affected templates in a new macro. That's what this patch does. The new libstdc++ acinclude.m4 test may well need wording changes in comments etc. and can perhaps be shortened a bit, bit it worked

Re: [fixincludes, v3] Don't define libstdc++-internal macros in Solaris 10+

2016-11-11 Thread Rainer Orth
Hi Bruce, > On 11/03/16 07:11, Rainer Orth wrote: >> >> Ok for mainline now, and for backports to the gcc-6 and gcc-5 branches >> after some soak time? > > Yes, please. Thanks. unfortunately, I didn't look closly enough when checking for failures. There is one which I thought was preexisting: m

Re: [fixincludes, v3] Don't define libstdc++-internal macros in Solaris 10+

2016-11-03 Thread Bruce Korb
On 11/03/16 07:11, Rainer Orth wrote: Ok for mainline now, and for backports to the gcc-6 and gcc-5 branches after some soak time? Yes, please. Thanks.

[fixincludes, v3] Don't define libstdc++-internal macros in Solaris 10+

2016-11-03 Thread Rainer Orth
As I've noticed some time ago, recent versions of Solaris include this little gem: #if __cplusplus >= 201103L #undef _GLIBCXX_USE_C99_MATH #undef _GLIBCXX_USE_C99_MATH_TR1 #endif This renders a couple of perfectly good libstdc++ tests as UNSUPPORTED and is completely unsustainable. Agreement