Re: [doc] Fix typo in gty.texi

2012-08-25 Thread Wei-Ren Chen
On Fri, Aug 24, 2012 at 10:05:06AM -0400, Diego Novillo wrote: > On 2012-08-23 06:55 , 陳韋任 (Wei-Ren Chen) wrote: > > >I think this is much clear than before. The word "modes" in "CFG takes > > various different modes" means different forms, GIMPLE or RTL, right? > > Right. Thanks. :) Rega

Re: [doc] Fix typo in gty.texi

2012-08-24 Thread Gerald Pfeifer
On Thu, 23 Aug 2012, Mingjie Xing wrote: > A very small patch. OK? > > 2012-08-23 Mingjie Xing > > * doc/gty.texi: Fix typo. By the way, changes of this kind, you can just commit and post the patch; they do not require approval. (When in doubt feel free to ask, of course.) Gerald

Re: [doc] Fix typo in gty.texi

2012-08-24 Thread Diego Novillo
On 2012-08-23 06:55 , 陳韋任 (Wei-Ren Chen) wrote: I think this is much clear than before. The word "modes" in "CFG takes various different modes" means different forms, GIMPLE or RTL, right? Right. Diego.

Re: [doc] Fix typo in gty.texi

2012-08-23 Thread Wei-Ren Chen
> During the expansion itself we have a mix of basic-blocks that are in RTL > and GIMPLE form. After expansion the CFG only contains RTL. The > sentence as-is is at least misleading, suggesting that after expansion > we have both RTL and GIMPLE in the CFG. > > So, on a second thought a more appr

Re: [doc] Fix typo in gty.texi

2012-08-23 Thread Richard Guenther
On Thu, Aug 23, 2012 at 12:28 PM, 陳韋任 (Wei-Ren Chen) wrote: > Hi Richard, > >> +representation. So the CFG simultaneously consist of basic blocks >> +containing RTL and GIMPLE trees. >> >> That last sentence is not correct, please remove it. Ok with that change. > > May I ask why the last sente

Re: [doc] Fix typo in gty.texi

2012-08-23 Thread Wei-Ren Chen
Hi Richard, > +representation. So the CFG simultaneously consist of basic blocks > +containing RTL and GIMPLE trees. > > That last sentence is not correct, please remove it. Ok with that change. May I ask why the last sentence is not correct? (just want to know why) The comment of gimple_expa

Re: [doc] Fix typo in gty.texi

2012-08-23 Thread Richard Guenther
On Thu, Aug 23, 2012 at 11:36 AM, 陳韋任 (Wei-Ren Chen) wrote: > Hi Richard, > > Could you review this patch, too? > http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01003.html +representation. So the CFG simultaneously consist of basic blocks +containing RTL and GIMPLE trees. That last sentence is

[doc] Fix typo in gty.texi

2012-08-23 Thread Wei-Ren Chen
Hi Richard, Could you review this patch, too? http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01003.html Thanks! Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.c

Re: [doc] Fix typo in gty.texi

2012-08-23 Thread Richard Guenther
On Thu, Aug 23, 2012 at 10:35 AM, Mingjie Xing wrote: > Hi, > > A very small patch. OK? Ok. Thanks, Richard. > 2012-08-23 Mingjie Xing > > * doc/gty.texi: Fix typo. > > Index: doc/gty.texi > === > --- doc/gty.texi

[doc] Fix typo in gty.texi

2012-08-23 Thread Mingjie Xing
Hi, A very small patch. OK? 2012-08-23 Mingjie Xing * doc/gty.texi: Fix typo. Index: doc/gty.texi === --- doc/gty.texi(revision 190611) +++ doc/gty.texi(working copy) @@ -666,7 +666,7 @@ The GCC build tr