Re: [committed] libstdc++: P1964R2 Wording for boolean-testable

2020-02-19 Thread Jonathan Wakely
On 18/02/20 13:49 +, Jonathan Wakely wrote: On 17/02/20 22:27 +0100, Tim Song wrote: On Mon, Feb 17, 2020 at 12:34 PM Jonathan Wakely wrote: This removes the complicated std::boolean concept, as agreed in Prague. * include/bits/ranges_algo.h (__find_fn, __find_first_of_fn)

Re: [committed] libstdc++: P1964R2 Wording for boolean-testable

2020-02-18 Thread Jonathan Wakely
On 17/02/20 22:27 +0100, Tim Song wrote: On Mon, Feb 17, 2020 at 12:34 PM Jonathan Wakely wrote: This removes the complicated std::boolean concept, as agreed in Prague. * include/bits/ranges_algo.h (__find_fn, __find_first_of_fn) (__adjacent_find_fn): Cast result of predicate

Re: [committed] libstdc++: P1964R2 Wording for boolean-testable

2020-02-17 Thread Tim Song
On Mon, Feb 17, 2020 at 12:34 PM Jonathan Wakely wrote: > This removes the complicated std::boolean concept, as agreed in Prague. > > * include/bits/ranges_algo.h (__find_fn, __find_first_of_fn) > (__adjacent_find_fn): Cast result of predicate to bool. Um, why? These look fine

[committed] libstdc++: P1964R2 Wording for boolean-testable

2020-02-17 Thread Jonathan Wakely
This removes the complicated std::boolean concept, as agreed in Prague. * include/bits/ranges_algo.h (__find_fn, __find_first_of_fn) (__adjacent_find_fn): Cast result of predicate to bool. * include/std/concepts (__boolean): Remove. (__detail::__boolean_testable_imp