Re: [committed] libstdc++: Fix BUILTIN-PTR-CMP helpers

2020-02-09 Thread Jonathan Wakely
On 09/02/20 13:56 +, Jonathan Wakely wrote: The helpers that implement BUILTIN-PTR-CMP do not currently check if the arguments are actually comparable, so the concept is true when it shouldn't be. Since we're trying to test for an unambiguous conversion to pointers, we can also require that

[committed] libstdc++: Fix BUILTIN-PTR-CMP helpers

2020-02-09 Thread Jonathan Wakely
The helpers that implement BUILTIN-PTR-CMP do not currently check if the arguments are actually comparable, so the concept is true when it shouldn't be. Since we're trying to test for an unambiguous conversion to pointers, we can also require that it returns bool, because the built-in comparisons