Re: [committed] Fix libffi/70024

2016-03-03 Thread Richard Henderson
On 03/03/2016 01:55 AM, Richard Biener wrote: Thanks for doing this. I suppose this is also upstream now? I'm re-syncing with upstream now. I did just find that upstream's soname is already 6.4.0, so I may come back and bump both sonames to 7 instead of 5. r~

Re: [committed] Fix libffi/70024

2016-03-03 Thread Richard Henderson
On 03/03/2016 05:35 AM, Rainer Orth wrote: Hi Richard, Unfortunately, even with this fixed, all Solaris/x86 tests now fail to link: FAIL: libffi.call/closure_fn0.c -W -Wall -Wno-psabi -O0 (test for excess errors) Excess errors: Undefined first referenced symbol

Re: [committed] Fix libffi/70024

2016-03-03 Thread Rainer Orth
Hi Richard, > Unfortunately, even with this fixed, all Solaris/x86 tests now fail to > link: > > FAIL: libffi.call/closure_fn0.c -W -Wall -Wno-psabi -O0 (test for excess > errors) > Excess errors: > Undefined first referenced > symbol in file > f

Re: [committed] Fix libffi/70024

2016-03-03 Thread Rainer Orth
Hi Richard, > As discussed in the PR, let's take the opportunity while bumping the soname > to add symbol versioning. great idea: I'd already suggested this back in 2010 when doing the bulk of the Solaris symbol versioning work http://gcc.gnu.org/ml/gcc/2010-02/msg00339.html http

Re: [committed] Fix libffi/70024

2016-03-03 Thread Richard Biener
On Thu, Mar 3, 2016 at 3:13 AM, Richard Henderson wrote: > [ Ho hum. Re-send due to spam rejection. > Trying again with compressed patch. ] > > > As discussed in the PR, let's take the opportunity while bumping the soname > to add symbol versioning. > > Versioning is complicated by the fact th

[committed] Fix libffi/70024

2016-03-02 Thread Richard Henderson
[ Ho hum. Re-send due to spam rejection. Trying again with compressed patch. ] As discussed in the PR, let's take the opportunity while bumping the soname to add symbol versioning. Versioning is complicated by the fact that there are several pieces of API that are "optional" based on the