> You've already got an ior_operand, which has a redundant test for CONST_INT.
> Actually, this is true of quite a few of the PA predicates...
Quite true. The predicates were originally derived from the code
in pa.md without a significant review.
I'll look at implementing your suggestion.
Thank
On 03/28/2011 03:10 PM, Richard Henderson wrote:
> On 03/27/2011 03:17 PM, John David Anglin wrote:
>> +(define_predicate "reg_or_ior_operand"
>> + (match_code "subreg,reg,const_int")
>> +{
>> + return (register_operand (op, mode)
>> + || (GET_CODE (op) == CONST_INT && ior_mask_p (INTVAL (op
On 03/27/2011 03:17 PM, John David Anglin wrote:
> +(define_predicate "reg_or_ior_operand"
> + (match_code "subreg,reg,const_int")
> +{
> + return (register_operand (op, mode)
> + || (GET_CODE (op) == CONST_INT && ior_mask_p (INTVAL (op;
> +})
> +
Better written, IMO, as
(ior (match
The following patch fixes a thinko in the iordi3 expander -- the
expander didn't allow register operands. I also changed the iorsi3
expander to use the new predicate.
Tested on hppa64-hp-hpux11.11 and hppa-unknown-linux-gnu with no
regressions. Committed to trunk.
Dave
--
J. David Anglin
