Re: [c-family PATCH] Fix for -Wlogical-op

2015-06-23 Thread Jeff Law
On 06/23/2015 07:12 AM, Marek Polacek wrote: While looking at something else I noticed that we're using == for INTEGER_CSTs comparison. That isn't going to work well, so use tree_int_cst_equal instead. Because of that we weren't diagnosing the following test. Bootstrapped/regtested on x86_64-l

[c-family PATCH] Fix for -Wlogical-op

2015-06-23 Thread Marek Polacek
While looking at something else I noticed that we're using == for INTEGER_CSTs comparison. That isn't going to work well, so use tree_int_cst_equal instead. Because of that we weren't diagnosing the following test. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2015-06-23 Marek Polacek