Re: [asan] change libasan to libsanitizer

2012-11-04 Thread Dodji Seketeli
Jakub Jelinek writes: > On Thu, Nov 01, 2012 at 02:52:52PM -0700, Xinliang David Li wrote: >> I think it is better to apply this patch to asan first to avoid extra >> thread. You probably just need to retrieve your runtime part of the >> trunk patch and resend it. Make sense? > > Yeah, for trun

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Wei Mi
The patch has been checked in. Committed revision 193074. Thanks, Wei. On Thu, Nov 1, 2012 at 3:16 PM, Wei Mi wrote: > Ok, I will check in the patch. > > Thanks, > Wei. > > On Thu, Nov 1, 2012 at 3:03 PM, Xinliang David Li wrote: >> On Thu, Nov 1, 2012 at 2:23 PM, Xinliang David Li wrote: >>>

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Wei Mi
Ok, I will check in the patch. Thanks, Wei. On Thu, Nov 1, 2012 at 3:03 PM, Xinliang David Li wrote: > On Thu, Nov 1, 2012 at 2:23 PM, Xinliang David Li wrote: >> On Thu, Nov 1, 2012 at 2:17 PM, Wei Mi wrote: >>> Thanks for the suggestion! >>> >>> The planned svn commands will be: >>> >>> svn

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Xinliang David Li
On Thu, Nov 1, 2012 at 2:23 PM, Xinliang David Li wrote: > On Thu, Nov 1, 2012 at 2:17 PM, Wei Mi wrote: >> Thanks for the suggestion! >> >> The planned svn commands will be: >> >> svn mv libasan libsanitizer >> svn add libsanitizer/asan >> svn add libsanitizer/tsan > > Probably keep the tsan cre

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Xinliang David Li
Yes, there is no need to repeat the error made in asan branch in trunk. David On Thu, Nov 1, 2012 at 2:55 PM, Jakub Jelinek wrote: > On Thu, Nov 01, 2012 at 02:52:52PM -0700, Xinliang David Li wrote: >> I think it is better to apply this patch to asan first to avoid extra >> thread. You probab

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Jakub Jelinek
On Thu, Nov 01, 2012 at 02:52:52PM -0700, Xinliang David Li wrote: > I think it is better to apply this patch to asan first to avoid extra > thread. You probably just need to retrieve your runtime part of the > trunk patch and resend it. Make sense? Yeah, for trunk I believe it would be better t

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Xinliang David Li
I think it is better to apply this patch to asan first to avoid extra thread. You probably just need to retrieve your runtime part of the trunk patch and resend it. Make sense? thanks, David On Thu, Nov 1, 2012 at 2:47 PM, Dodji Seketeli wrote: > Instead of planning this change for the branch

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Dodji Seketeli
Instead of planning this change for the branch, would it be possible to plan it for trunk directly, on top of the patches that I posted for review there? The patch could go in on top of the patches I posted. Wei Mi writes: > This is the part2. > > On Thu, Nov 1, 2012 at 1:02 PM, Wei Mi wrote:

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Xinliang David Li
On Thu, Nov 1, 2012 at 2:17 PM, Wei Mi wrote: > Thanks for the suggestion! > > The planned svn commands will be: > > svn mv libasan libsanitizer > svn add libsanitizer/asan > svn add libsanitizer/tsan Probably keep the tsan creation out of this patch. David > cd libsanitizer > for i in `ls asan

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Xinliang David Li
that sounds good to me. David On Thu, Nov 1, 2012 at 1:31 PM, Jakub Jelinek wrote: > On Thu, Nov 01, 2012 at 01:19:42PM -0700, Xinliang David Li wrote: >> Will it be easier if you just rolled back your previous libasan >> library changes, and resubmit it with the restructured directory? > > I th

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Jakub Jelinek
On Thu, Nov 01, 2012 at 01:19:42PM -0700, Xinliang David Li wrote: > Will it be easier if you just rolled back your previous libasan > library changes, and resubmit it with the restructured directory? I think better would be if you didn't apply it as a patch with lots of svn add/svn rm commands, b

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Wei Mi
Yes. That will be easier and clearer. The patch is too big. Thanks, Wei. On Thu, Nov 1, 2012 at 1:19 PM, Xinliang David Li wrote: > Will it be easier if you just rolled back your previous libasan > library changes, and resubmit it with the restructured directory? > > David > > On Thu, Nov 1, 201

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Xinliang David Li
Will it be easier if you just rolled back your previous libasan library changes, and resubmit it with the restructured directory? David On Thu, Nov 1, 2012 at 1:17 PM, Wei Mi wrote: > patch.part2.txt.bz2 and patch.part3.txt.bz2 are still too big. > > Divide patch.part2.txt.bz2 into two parts: >

[asan] change libasan to libsanitizer

2012-11-01 Thread Wei Mi
Hi, Here is the patch to change libasan to libsanitizer and reorganize the directory. I divided the patch into three parts for review. patch.part1.txt: Contains the changes in the outermost level. patch.part2.txt.bz2: Remove libasan patch.part3.txt.bz2: Add libsanitizer Is it ok for asan branch?