Re: [asan] Protection of stack vars (take 2)

2012-10-16 Thread Xinliang David Li
On Tue, Oct 16, 2012 at 2:52 PM, Jakub Jelinek wrote: > On Tue, Oct 16, 2012 at 01:56:46PM -0700, Xinliang David Li wrote: >> Looks good except for the following: >> >> 1) I am not sure if the stack slot sharing is handled correctly. If I >> read the code correctly, the redzone var will be only cr

Re: [asan] Protection of stack vars (take 2)

2012-10-16 Thread Jakub Jelinek
On Tue, Oct 16, 2012 at 01:56:46PM -0700, Xinliang David Li wrote: > Looks good except for the following: > > 1) I am not sure if the stack slot sharing is handled correctly. If I > read the code correctly, the redzone var will be only created for the > representative variable in a partition -- wi

Re: [asan] Protection of stack vars (take 2)

2012-10-16 Thread Xinliang David Li
Looks good except for the following: 1) I am not sure if the stack slot sharing is handled correctly. If I read the code correctly, the redzone var will be only created for the representative variable in a partition -- will this lead to false negatives? As I asked before, should stack slot sharing

[asan] Protection of stack vars (take 2)

2012-10-16 Thread Jakub Jelinek
Hi! Here is an updated patch, which emits also the shadow clearing sequence at the end of function in the right spot. 2012-10-16 Jakub Jelinek * Makefile.in (asan.o): Depend on $(EXPR_H) $(OPTABS_H). (cfgexpand.o): Depend on asan.h. * asan.c: Include expr.h and optabs.