Re: [asan] Handle bitfields in asan

2012-12-08 Thread Dodji Seketeli
Jakub Jelinek writes: > 2012-12-05 Jakub Jelinek > > * asan.c (instrument_derefs): Handle bitfield COMPONENT_REFs > accesses as reads/writes to their DECL_BIT_FIELD_REPRESENTATIVE. After Richi's comments in this thread, I guess this is OK to me. -- Dodji

Re: [asan] Handle bitfields in asan

2012-12-06 Thread Richard Biener
On Wed, 5 Dec 2012, Jakub Jelinek wrote: > On Wed, Dec 05, 2012 at 05:10:56PM +0100, Richard Biener wrote: > > > This patch tries to handle bitfield accesses as if it were writes/reads > > > from the corresponding DECL_BIT_FIELD_REPRESENTATIVE. > > > Richard, does it make sense this way (the code

Re: [asan] Handle bitfields in asan

2012-12-05 Thread Jakub Jelinek
On Wed, Dec 05, 2012 at 05:10:56PM +0100, Richard Biener wrote: > > This patch tries to handle bitfield accesses as if it were writes/reads > > from the corresponding DECL_BIT_FIELD_REPRESENTATIVE. > > Richard, does it make sense this way (the code will take ADDR_EXPR > > of the COMPONENT_REF with

Re: [asan] Handle bitfields in asan

2012-12-05 Thread Richard Biener
On Wed, 5 Dec 2012, Jakub Jelinek wrote: > Hi! > > This patch tries to handle bitfield accesses as if it were writes/reads > from the corresponding DECL_BIT_FIELD_REPRESENTATIVE. > Richard, does it make sense this way (the code will take ADDR_EXPR > of the COMPONENT_REF with the DECL_BIT_FIELD_RE

[asan] Handle bitfields in asan

2012-12-05 Thread Jakub Jelinek
Hi! This patch tries to handle bitfield accesses as if it were writes/reads from the corresponding DECL_BIT_FIELD_REPRESENTATIVE. Richard, does it make sense this way (the code will take ADDR_EXPR of the COMPONENT_REF with the DECL_BIT_FIELD_REPRESENTATIVE and use the size of the representative if