Re: [aarch64}: added variable issue rate feature for falkor

2018-10-16 Thread Kyrill Tkachov
Hi Kai, On 11/10/18 16:25, Kai Tietz wrote: Hi, I reworked patch use a tuning flag instead of checking explicit for CPU flavor. I will send soon an update for it, which won't use the static variable anymore, and uses instead the SCHED-api. I would like first to get some comments on current ver

Re: [aarch64}: added variable issue rate feature for falkor

2018-10-11 Thread Kai Tietz
Hi, I reworked patch use a tuning flag instead of checking explicit for CPU flavor. I will send soon an update for it, which won't use the static variable anymore, and uses instead the SCHED-api. I would like first to get some comments on current version. Regards, Kai Jim Wilson

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-15 Thread Steve Ellcey
On Wed, 2018-08-15 at 12:45 +0200, Kai Tietz wrote: >  > > I believe the scheduler provides hooks specifically for storing > > backend-specific scheduling state so we should > > avoid creating such static variables in aarch64.c. Can you use the > > TARGET_SCHED_*_SCHED_CONTEXT family of hooks here?

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-15 Thread Kai Tietz
Hello Kyrill, thanks for your comments. 2018-08-14 16:50 GMT+02:00 Kyrill Tkachov : > Hi Kai, > > > On 13/08/18 17:48, Kai Tietz wrote: >> >> I repost updated patch containing ChangeLog entry. >> >> Regards, >> Kai > > > I think I understand what this patch does, please correct me if I'm wrong.

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-14 Thread Kyrill Tkachov
Hi Kai, On 13/08/18 17:48, Kai Tietz wrote: I repost updated patch containing ChangeLog entry. Regards, Kai I think I understand what this patch does, please correct me if I'm wrong. You model the processors micro-ops and some A64 instructions use multiple micro-ops. This is what the falkor_

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-13 Thread Kai Tietz
I repost updated patch containing ChangeLog entry. Regards, Kai Jim Wilson Kai Tietz * config/aarch64.c (aarch64_sched_reorder): Implement TARGET_SCHED_REORDER hook. (aarch64_variable_issue): Implement TARGET_SCHED_VARIABLE_ISSUE hook. (TARGET_SCHED_REORDER): Define. (TARGET_SCHED_VARIA

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-13 Thread Kai Tietz
2018-08-13 18:23 GMT+02:00 Segher Boessenkool : > I cannot okay patches for aarch64. But I did not notice other typoes, > if that is what you're asking. Yes. Thanks. So, is patch ok with updated ChangeLog: Jim Wilson Kai Tietz * config/aarch64.c (aarch64_sched_reorder

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-13 Thread Segher Boessenkool
On Mon, Aug 13, 2018 at 06:13:58PM +0200, Kai Tietz wrote: > 2018-08-13 17:51 GMT+02:00 Segher Boessenkool : > > On Mon, Aug 13, 2018 at 10:16:20AM +0200, Kai Tietz wrote: > >> * config/aarch64.c (aarch64_sched_reorder): Implementing > >> TARGET_SHED_REORDER hook. > >> (aarc

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-13 Thread Kai Tietz
2018-08-13 17:51 GMT+02:00 Segher Boessenkool : > Hi! > > On Mon, Aug 13, 2018 at 10:16:20AM +0200, Kai Tietz wrote: >> * config/aarch64.c (aarch64_sched_reorder): Implementing >> TARGET_SHED_REORDER hook. >> (aarch64_variable_issue): Implemented TARGET_SHED_VARIABLE_ISSUE >

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-13 Thread Segher Boessenkool
Hi! On Mon, Aug 13, 2018 at 10:16:20AM +0200, Kai Tietz wrote: > * config/aarch64.c (aarch64_sched_reorder): Implementing > TARGET_SHED_REORDER hook. > (aarch64_variable_issue): Implemented TARGET_SHED_VARIABLE_ISSUE > hook. > (TARGET_SHED_REORDER): Defined.

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-13 Thread Kai Tietz
2018-08-13 15:43 GMT+02:00 Bernhard Reutner-Fischer : > On 13 August 2018 15:12:30 CEST, Bernhard Reutner-Fischer > wrote: >>On 13 August 2018 10:16:20 CEST, Kai Tietz >>wrote: >>>Hello, >>> >>>this patch implements variable issue rate feature for falkor cpu. >>>Additionally this patch adjusts t

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-13 Thread Bernhard Reutner-Fischer
On 13 August 2018 15:12:30 CEST, Bernhard Reutner-Fischer wrote: >On 13 August 2018 10:16:20 CEST, Kai Tietz >wrote: >>Hello, >> >>this patch implements variable issue rate feature for falkor cpu. >>Additionally this patch adjusts the issue rate for falkor 8 as this >>value reflects more cpu's s

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-13 Thread Bernhard Reutner-Fischer
On 13 August 2018 10:16:20 CEST, Kai Tietz wrote: >Hello, > >this patch implements variable issue rate feature for falkor cpu. >Additionally this patch adjusts the issue rate for falkor 8 as this >value reflects more cpu's specification. > >This patch was tested against SPEC 2017 & 2016 and showed

[aarch64}: added variable issue rate feature for falkor

2018-08-13 Thread Kai Tietz
Hello, this patch implements variable issue rate feature for falkor cpu. Additionally this patch adjusts the issue rate for falkor 8 as this value reflects more cpu's specification. This patch was tested against SPEC 2017 & 2016 and showed in general some improvements without any regressions for