Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Qing Zhao via Gcc-patches
> On Mar 27, 2023, at 12:48 PM, Qing Zhao via Gcc-patches > wrote: > > > >> On Mar 27, 2023, at 12:31 PM, Jakub Jelinek wrote: >> >> On Mon, Mar 27, 2023 at 04:22:25PM +, Qing Zhao via Gcc-patches wrote: The latter IMHO. Having a warning with completely nonsensical name will

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Qing Zhao via Gcc-patches
> On Mar 27, 2023, at 12:31 PM, Jakub Jelinek wrote: > > On Mon, Mar 27, 2023 at 04:22:25PM +, Qing Zhao via Gcc-patches wrote: >>> The latter IMHO. Having a warning with completely nonsensical name will >>> just confuse users. >> >> Okay. -:) >> How about "-Wstruct-with-fam-not-at-end”?

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Jakub Jelinek via Gcc-patches
On Mon, Mar 27, 2023 at 04:22:25PM +, Qing Zhao via Gcc-patches wrote: > > The latter IMHO. Having a warning with completely nonsensical name will > > just confuse users. > > Okay. -:) > How about "-Wstruct-with-fam-not-at-end”? Or do you have any suggestion on > the name? Nobody will know

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Qing Zhao via Gcc-patches
> On Mar 27, 2023, at 12:06 PM, Jakub Jelinek wrote: > > On Mon, Mar 27, 2023 at 03:57:58PM +, Qing Zhao wrote: +Please use warning option @option{-Wgnu-variable-sized-type-not-at-end} to >>> This is certainly misnamed. >> >> The name “-Wgnu-variable-sized-type-not-at-end” was

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Jakub Jelinek via Gcc-patches
On Mon, Mar 27, 2023 at 03:57:58PM +, Qing Zhao wrote: > >> +Please use warning option @option{-Wgnu-variable-sized-type-not-at-end} > >> to > > This is certainly misnamed. > > The name “-Wgnu-variable-sized-type-not-at-end” was just used the warning > name from CLANG. -:) > > Shall we use

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Qing Zhao via Gcc-patches
> On Mar 27, 2023, at 11:43 AM, Jakub Jelinek wrote: > > On Mon, Mar 27, 2023 at 01:38:34PM +, Qing Zhao wrote: >> >> >>> On Mar 23, 2023, at 4:14 PM, Joseph Myers wrote: >>> >>> On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote: >>> +Wgnu-variable-sized-type-not-at-end +C

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Jakub Jelinek via Gcc-patches
On Mon, Mar 27, 2023 at 01:38:34PM +, Qing Zhao wrote: > > > > On Mar 23, 2023, at 4:14 PM, Joseph Myers wrote: > > > > On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote: > > > >> +Wgnu-variable-sized-type-not-at-end > >> +C C++ Var(warn_variable_sized_type_not_at_end) Warning > >> +War

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Qing Zhao via Gcc-patches
> On Mar 27, 2023, at 10:34 AM, Xi Ruoyao wrote: > > On Mon, 2023-03-27 at 13:38 +, Qing Zhao via Gcc-patches wrote: >> >> >>> On Mar 23, 2023, at 4:14 PM, Joseph Myers wrote: >>> >>> On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote: >>> +Wgnu-variable-sized-type-not-at-end >>

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Xi Ruoyao via Gcc-patches
On Mon, 2023-03-27 at 13:38 +, Qing Zhao via Gcc-patches wrote: > > > > On Mar 23, 2023, at 4:14 PM, Joseph Myers wrote: > > > > On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote: > > > > > +Wgnu-variable-sized-type-not-at-end > > > +C C++ Var(warn_variable_sized_type_not_at_end) Warnin

Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-27 Thread Qing Zhao via Gcc-patches
> On Mar 23, 2023, at 4:14 PM, Joseph Myers wrote: > > On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote: > >> +Wgnu-variable-sized-type-not-at-end >> +C C++ Var(warn_variable_sized_type_not_at_end) Warning >> +Warn about structures or unions with C99 flexible array members are not >> +at

Re: Fwd: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-23 Thread Joseph Myers
On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote: > +Wgnu-variable-sized-type-not-at-end > +C C++ Var(warn_variable_sized_type_not_at_end) Warning > +Warn about structures or unions with C99 flexible array members are not > +at the end of a structure. I think there's at least one word missing

Fwd: [V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-23 Thread Qing Zhao via Gcc-patches
Ping… Please let me know if you have any further comments on the patch. thanks. Qing Begin forwarded message: From: Qing Zhao mailto:qing.z...@oracle.com>> Subject: [V5][PATCH 2/2] Update documentation to clarify a GCC extension Date: March 16, 2023 at 5:47:15 PM EDT T

[V5][PATCH 2/2] Update documentation to clarify a GCC extension

2023-03-16 Thread Qing Zhao via Gcc-patches
on a structure with a C99 flexible array member being nested in another structure. (PR77650) "GCC extension accepts a structure containing an ISO C99 "flexible array member", or a union containing such a structure (possibly recursively) to be a member of a structure. There are two situations: