Re: [SH] PR 51244 - Add CANONICALIZE_COMPARISON macro

2012-09-04 Thread Oleg Endo
On Mon, 2012-09-03 at 19:37 +0900, Kaz Kojima wrote: > Oleg Endo wrote: > > In any case, I have no problem with changing the multi line comments > > to /* ... */. Just let me know. > > Other than that, the patch is OK. I've committed the attached version of the patch as rev 190909. Cheers, O

Re: [SH] PR 51244 - Add CANONICALIZE_COMPARISON macro

2012-09-03 Thread Kaz Kojima
Oleg Endo wrote: > In any case, I have no problem with changing the multi line comments > to /* ... */. Just let me know. Other than that, the patch is OK. Regards, kaz

Re: [SH] PR 51244 - Add CANONICALIZE_COMPARISON macro

2012-09-03 Thread Oleg Endo
On 3 Sep 2012, at 11:18, Kaz Kojima wrote: Oleg Endo wrote: --- gcc/config/sh/sh.c(revision 190840) +++ gcc/config/sh/sh.c(working copy) @@ -21,6 +21,12 @@ along with GCC; see the file COPYING3. If not see . */ +/* FIXME: This is a temporary hack, so t

Re: [SH] PR 51244 - Add CANONICALIZE_COMPARISON macro

2012-09-03 Thread Kaz Kojima
Oleg Endo wrote: > --- gcc/config/sh/sh.c(revision 190840) > +++ gcc/config/sh/sh.c(working copy) > @@ -21,6 +21,12 @@ > along with GCC; see the file COPYING3. If not see > . */ > > +/* FIXME: This is a temporary hack, so that we can include > +

[SH] PR 51244 - Add CANONICALIZE_COMPARISON macro

2012-09-03 Thread Oleg Endo
Hello, This adds implementation of the CANONICALIZE_COMPARISON macro to the SH target. So far, it doesn't seem to have an impact on the generated code, but it might be useful to have it in place in the future. Moreover, it changes the behavior of the cbranchsi4 expander, which was checking for TA