Re: [SH] PR 30807 - Add test case

2013-11-21 Thread Hans-Peter Nilsson
On Tue, 5 Nov 2013, Mike Stump wrote: > On Nov 5, 2013, at 1:45 PM, Oleg Endo wrote: > > You're right, it's redundant. It should be just > > /* { dg-do compile } */ > > > > shouldn't it? > > Yup, that's my take. Or nothing at all, as compile seems to be the default here. (grep for dg-do-what-de

Re: [SH] PR 30807 - Add test case

2013-11-06 Thread Mike Stump
On Nov 6, 2013, at 2:33 PM, Oleg Endo wrote: > I've committed the attached patch as rev 204487. I doubled checked the patch, all looks good, thanks for the work.

Re: [SH] PR 30807 - Add test case

2013-11-05 Thread Kaz Kojima
Oleg Endo wrote: > This adds a test case for PR 30807 which is based on the PR's attachment > 17961. Tested with > make -k check-gcc RUNTESTFLAGS="sh-torture.exp --target_board=sh-sim > \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb} > > OK to add? OK with the changes suggested by

Re: [SH] PR 30807 - Add test case

2013-11-05 Thread Mike Stump
On Nov 5, 2013, at 1:45 PM, Oleg Endo wrote: > You're right, it's redundant. It should be just > /* { dg-do compile } */ > > shouldn't it? Yup, that's my take. > I can change that before committing, no problem. Thanks.

Re: [SH] PR 30807 - Add test case

2013-11-05 Thread Oleg Endo
On Tue, 2013-11-05 at 13:33 -0800, Mike Stump wrote: > On Nov 5, 2013, at 12:44 PM, Oleg Endo wrote: > > +/* { dg-do compile { target "sh*-*-*" } } */ > > Why do this, when sh-torture.exp does this: > > if { ![istarget sh*-*-*] } then { > return > } > > ? I suspect you merely copied the styl

Re: [SH] PR 30807 - Add test case

2013-11-05 Thread Mike Stump
On Nov 5, 2013, at 12:44 PM, Oleg Endo wrote: > +/* { dg-do compile { target "sh*-*-*" } } */ Why do this, when sh-torture.exp does this: if { ![istarget sh*-*-*] } then { return } ? I suspect you merely copied the style from the other test cases. If there isn't a good reason to do this, p

[SH] PR 30807 - Add test case

2013-11-05 Thread Oleg Endo
Hi, This adds a test case for PR 30807 which is based on the PR's attachment 17961. Tested with make -k check-gcc RUNTESTFLAGS="sh-torture.exp --target_board=sh-sim \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb} OK to add? Cheers, Oleg testsuite/ChangeLog: PR target/308