Re: [RS6000] Power10 libffi fixes

2020-09-23 Thread Alan Modra via Gcc-patches
On Thu, Sep 24, 2020 at 01:11:02PM +0930, Alan Modra wrote: > I've fixed the changelog, a comment, and added a nop after bl for the > old calls without @notoc. While there really isn't a need for the > nops in libffi.so since the callee is hidden visibility, there is a > miniscule chance that a st

Re: [RS6000] Power10 libffi fixes

2020-09-23 Thread Alan Modra via Gcc-patches
On Tue, Sep 22, 2020 at 07:16:57PM -0500, Segher Boessenkool wrote: > Hi! > > On Tue, Sep 22, 2020 at 10:00:11AM +0930, Alan Modra wrote: > > gcc/ > > * config/rs6000/rs6000-c.c (rs6000_target_modify_macros): > > Conditionally define __PCREL__. > > Please do that as a separate (earlier) p

Re: [RS6000] Power10 libffi fixes

2020-09-22 Thread Segher Boessenkool
Hi! On Tue, Sep 22, 2020 at 10:00:11AM +0930, Alan Modra wrote: > Power10 pc-relative code doesn't use or preserve r2 as a TOC pointer. > That means calling between pc-relative and TOC using code can't be > done without intervening linker stubs, and a call from TOC code to > pc-relative code must

[RS6000] Power10 libffi fixes

2020-09-21 Thread Alan Modra via Gcc-patches
Power10 pc-relative code doesn't use or preserve r2 as a TOC pointer. That means calling between pc-relative and TOC using code can't be done without intervening linker stubs, and a call from TOC code to pc-relative code must have a nop after the bl in order to restore r2. Now the PowerPC libffi a