Re: [RFC PATCH] avoid printing type suffix with %E (PR c/78165)

2016-12-09 Thread Martin Sebor
The check-in lacked the gcc/testsuite ChangeLog. Besides, the patch caused a testsuite regression on Solaris with /bin/as (sparc and x86, 32 and 64-bit): +FAIL: g++.dg/debug/dwarf2/typedef1.C -std=gnu++11 scan-assembler-times DW_AT_name: "foo<1>"|"foo<1u>.."[^\\n]*DW_AT_name 1 +FAIL: g++.dg/d

Re: [RFC PATCH] avoid printing type suffix with %E (PR c/78165)

2016-12-09 Thread Rainer Orth
Jeff Law writes: > On 11/19/2016 02:04 PM, Martin Sebor wrote: >> On 10/26/2016 02:46 PM, Joseph Myers wrote: >>> On Wed, 26 Oct 2016, Martin Sebor wrote: >>> The attached patch implements one such approach by having the pretty printer recognize the space format flag to suppress the typ

Re: [RFC PATCH] avoid printing type suffix with %E (PR c/78165)

2016-11-29 Thread Jeff Law
On 11/19/2016 02:04 PM, Martin Sebor wrote: On 10/26/2016 02:46 PM, Joseph Myers wrote: On Wed, 26 Oct 2016, Martin Sebor wrote: The attached patch implements one such approach by having the pretty printer recognize the space format flag to suppress the type suffix, so "%E" still prints the su

Re: [RFC PATCH] avoid printing type suffix with %E (PR c/78165)

2016-11-19 Thread Martin Sebor
On 10/26/2016 02:46 PM, Joseph Myers wrote: On Wed, 26 Oct 2016, Martin Sebor wrote: The attached patch implements one such approach by having the pretty printer recognize the space format flag to suppress the type suffix, so "%E" still prints the suffix but "% E" does not. I did this to prese

Re: [RFC PATCH] avoid printing type suffix with %E

2016-11-16 Thread Martin Sebor
On 11/16/2016 11:34 AM, Jeff Law wrote: On 10/26/2016 10:37 AM, Martin Sebor wrote: When formatting an integer constant using the %E directive GCC includes a suffix that indicates its type. This can perhaps be useful in some situations but in my experience it's distracting and gets in the way w

Re: [RFC PATCH] avoid printing type suffix with %E

2016-11-16 Thread Jeff Law
On 10/26/2016 10:37 AM, Martin Sebor wrote: When formatting an integer constant using the %E directive GCC includes a suffix that indicates its type. This can perhaps be useful in some situations but in my experience it's distracting and gets in the way when writing tests. Here's an example:

Re: [RFC PATCH] avoid printing type suffix with %E

2016-10-26 Thread Joseph Myers
On Wed, 26 Oct 2016, Martin Sebor wrote: > The attached patch implements one such approach by having the pretty > printer recognize the space format flag to suppress the type suffix, > so "%E" still prints the suffix but "% E" does not. I did this to > preserve the existing output but I think it

[RFC PATCH] avoid printing type suffix with %E

2016-10-26 Thread Martin Sebor
When formatting an integer constant using the %E directive GCC includes a suffix that indicates its type. This can perhaps be useful in some situations but in my experience it's distracting and gets in the way when writing tests. Here's an example: $ cat b.c && gcc b.c constexpr __SIZE_TYPE