Re: [RFC PATCH] RISC-V: Remove f{r,s}flags builtins

2023-11-29 Thread Philipp Tomsich
These build-ins are used internally for the TARGET_ATOMIC_ASSIGN_EXPAND_FENV expansion (and therefore can not be removed): /* Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV. */ void riscv_atomic_assign_expand_fenv (tree *hold, tree *clear, tree *update) { if (!(TARGET_HARD_FLOAT || TARGET_ZFINX))

Re: [RFC PATCH] RISC-V: Remove f{r,s}flags builtins

2023-11-29 Thread Christoph Müllner
On Wed, Nov 29, 2023 at 8:24 PM Patrick O'Neill wrote: > > Hi Christoph, > > The precommit-ci is seeing a large number of ICE segmentation faults as a > result of this patch: > https://github.com/ewlu/gcc-precommit-ci/issues/796#issuecomment-1831853523 > > The failures aren't in riscv.exp testsui

Re: [RFC PATCH] RISC-V: Remove f{r,s}flags builtins

2023-11-29 Thread Patrick O'Neill
Hi Christoph, The precommit-ci is seeing a large number of ICE segmentation faults as a result of this patch: https://github.com/ewlu/gcc-precommit-ci/issues/796#issuecomment-1831853523 The failures aren't in riscv.exp testsuite files so that's likely why you didn't run into them in your test

[RFC PATCH] RISC-V: Remove f{r,s}flags builtins

2023-11-29 Thread Christoph Muellner
From: Christoph Müllner We have two builtins which are undocumented and have no known users. Further, they don't exist in LLVM (so are no portable). This means they are in an unclear state of being supported or not. Let's remove them get them out of this undecided state. A discussion about makin