Re: [RFC PATCH] Do not cache SLP trees across SLP instances [PR116352]

2024-08-30 Thread Richard Biener
On Fri, 30 Aug 2024, Manolis Tsamis wrote: > On Fri, Aug 30, 2024 at 2:24 PM Richard Biener wrote: > > > > On Fri, 30 Aug 2024, Manolis Tsamis wrote: > > > > > For more context please see > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116352#c11. > > > > > > I've sent this as an RFC because i

Re: [RFC PATCH] Do not cache SLP trees across SLP instances [PR116352]

2024-08-30 Thread Manolis Tsamis
On Fri, Aug 30, 2024 at 2:24 PM Richard Biener wrote: > > On Fri, 30 Aug 2024, Manolis Tsamis wrote: > > > For more context please see > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116352#c11. > > > > I've sent this as an RFC because it's hard to be sure that this was > > just uncovered by r15-

Re: [RFC PATCH] Do not cache SLP trees across SLP instances [PR116352]

2024-08-30 Thread Richard Biener
On Fri, 30 Aug 2024, Manolis Tsamis wrote: > For more context please see > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116352#c11. > > I've sent this as an RFC because it's hard to be sure that this was > just uncovered by r15-2820-gab18785840d7b8 rather than being > introduced by it. > Still, t

Re: [RFC PATCH] Do not cache SLP trees across SLP instances [PR116352]

2024-08-30 Thread Manolis Tsamis
For more context please see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116352#c11. I've sent this as an RFC because it's hard to be sure that this was just uncovered by r15-2820-gab18785840d7b8 rather than being introduced by it. Still, to the best of my knowledge after reading through the code,

[RFC PATCH] Do not cache SLP trees across SLP instances [PR116352]

2024-08-30 Thread Manolis Tsamis
Currently we do SLP CSE after permute optimization using a single map across all SLP instances. These SLP instances can affect many different basic blocks and the cache may replace a statement in one block with one from another block. Because there are no further limitations and the blocks may be v