Re: [RFC PATCH, i386]: Make FP inequality comparisons trapping on qNaN.

2017-10-22 Thread Uros Bizjak
On Fri, Oct 20, 2017 at 9:48 PM, Uros Bizjak wrote: > On Fri, Oct 20, 2017 at 2:15 PM, Joseph Myers wrote: > >> This is PR target/52451. >> >> A testcase (conditional on the fenv_exceptions effective-target) that >> ordered comparisons with quiet NaNs set FE_INVALID would be a good idea, >> but i

Re: [RFC PATCH, i386]: Make FP inequality comparisons trapping on qNaN.

2017-10-20 Thread Uros Bizjak
On Fri, Oct 20, 2017 at 2:15 PM, Joseph Myers wrote: > This is PR target/52451. > > A testcase (conditional on the fenv_exceptions effective-target) that > ordered comparisons with quiet NaNs set FE_INVALID would be a good idea, > but it would need XFAILing for powerpc (bug 58684) and s390 (bug 7

Re: [RFC PATCH, i386]: Make FP inequality comparisons trapping on qNaN.

2017-10-20 Thread Joseph Myers
On Fri, 20 Oct 2017, Uros Bizjak wrote: > 2017-10-20 Uros Bizjak > > * config/i386/i386.c (ix86_fp_compare_mode): Return CCFPmode > for ordered inequality comparisons even with TARGET_IEEE_FP. This is PR target/52451. A testcase (conditional on the fenv_exceptions effective-target) t

[RFC PATCH, i386]: Make FP inequality comparisons trapping on qNaN.

2017-10-20 Thread Uros Bizjak
Hello! Attached patch makes FP inequality comparisons trap on qNaN. There is an old comment mentioned reversible comparisons, but middle end doesn't reverse them anymore (a couple of weeks ago, reversed comparisons were removed from i386.md): /* ??? In order to make all comparisons reversible, we