Re: [RFC] Fix recent popcount change is breaking

2018-11-23 Thread Bin.Cheng
On Sat, Jul 28, 2018 at 7:36 AM Kugan Vivekanandarajah wrote: > > Hi, > > On 28 July 2018 at 01:13, Richard Biener wrote: > > On July 27, 2018 3:33:59 PM GMT+02:00, "Martin Liška" > > wrote: > >>On 07/11/2018 02:31 PM, Richard Biener wrote: > >>> Why not simply make popcountdi available in the

Re: [RFC] Fix recent popcount change is breaking

2018-07-27 Thread Kugan Vivekanandarajah
Hi, On 28 July 2018 at 01:13, Richard Biener wrote: > On July 27, 2018 3:33:59 PM GMT+02:00, "Martin Liška" wrote: >>On 07/11/2018 02:31 PM, Richard Biener wrote: >>> Why not simply make popcountdi available in the kernel? They do have >>> implementations for other libgcc functions IIRC. >> >>C

Re: [RFC] Fix recent popcount change is breaking

2018-07-27 Thread Richard Biener
On July 27, 2018 3:33:59 PM GMT+02:00, "Martin Liška" wrote: >On 07/11/2018 02:31 PM, Richard Biener wrote: >> Why not simply make popcountdi available in the kernel? They do have >> implementations for other libgcc functions IIRC. > >Can you please Kugan create Linux kernel bug for that? So that

Re: [RFC] Fix recent popcount change is breaking

2018-07-27 Thread Martin Liška
On 07/11/2018 02:31 PM, Richard Biener wrote: > Why not simply make popcountdi available in the kernel? They do have > implementations for other libgcc functions IIRC. Can you please Kugan create Linux kernel bug for that? So that discussion can happen? Thanks, Martin

Re: [RFC] Fix recent popcount change is breaking

2018-07-11 Thread Richard Biener
On Wed, Jul 11, 2018 at 1:26 PM Kugan Vivekanandarajah wrote: > > Hi Andrew, > > On 11 July 2018 at 15:43, Andrew Pinski wrote: > > On Tue, Jul 10, 2018 at 6:35 PM Kugan Vivekanandarajah > > wrote: > >> > >> Hi Andrew, > >> > >> On 11 July 2018 at 11:19, Andrew Pinski wrote: > >> > On Tue, Jul

Re: [RFC] Fix recent popcount change is breaking

2018-07-11 Thread Kugan Vivekanandarajah
Hi Andrew, On 11 July 2018 at 15:43, Andrew Pinski wrote: > On Tue, Jul 10, 2018 at 6:35 PM Kugan Vivekanandarajah > wrote: >> >> Hi Andrew, >> >> On 11 July 2018 at 11:19, Andrew Pinski wrote: >> > On Tue, Jul 10, 2018 at 6:14 PM Kugan Vivekanandarajah >> > wrote: >> >> >> >> On 10 July 2018

Re: [RFC] Fix recent popcount change is breaking

2018-07-10 Thread Andrew Pinski
On Tue, Jul 10, 2018 at 6:35 PM Kugan Vivekanandarajah wrote: > > Hi Andrew, > > On 11 July 2018 at 11:19, Andrew Pinski wrote: > > On Tue, Jul 10, 2018 at 6:14 PM Kugan Vivekanandarajah > > wrote: > >> > >> On 10 July 2018 at 23:17, Richard Biener > >> wrote: > >> > On Tue, Jul 10, 2018 at 3:

Re: [RFC] Fix recent popcount change is breaking

2018-07-10 Thread Kugan Vivekanandarajah
Hi Andrew, On 11 July 2018 at 11:19, Andrew Pinski wrote: > On Tue, Jul 10, 2018 at 6:14 PM Kugan Vivekanandarajah > wrote: >> >> On 10 July 2018 at 23:17, Richard Biener wrote: >> > On Tue, Jul 10, 2018 at 3:06 PM Kugan Vivekanandarajah >> > wrote: >> >> >> >> Hi, >> >> >> >> Jeff told me tha

Re: [RFC] Fix recent popcount change is breaking

2018-07-10 Thread Andrew Pinski
On Tue, Jul 10, 2018 at 6:14 PM Kugan Vivekanandarajah wrote: > > On 10 July 2018 at 23:17, Richard Biener wrote: > > On Tue, Jul 10, 2018 at 3:06 PM Kugan Vivekanandarajah > > wrote: > >> > >> Hi, > >> > >> Jeff told me that the recent popcount built-in detection is causing > >> kernel build is

Re: [RFC] Fix recent popcount change is breaking

2018-07-10 Thread Kugan Vivekanandarajah
On 10 July 2018 at 23:17, Richard Biener wrote: > On Tue, Jul 10, 2018 at 3:06 PM Kugan Vivekanandarajah > wrote: >> >> Hi, >> >> Jeff told me that the recent popcount built-in detection is causing >> kernel build issues as >> ERROR: "__popcountsi2" >> [drivers/net/wireless/broadcom/brcm80211/brc

Re: [RFC] Fix recent popcount change is breaking

2018-07-10 Thread Jeff Law
On 07/10/2018 07:27 AM, Jakub Jelinek wrote: > On Tue, Jul 10, 2018 at 03:17:48PM +0200, Richard Biener wrote: >> On Tue, Jul 10, 2018 at 3:06 PM Kugan Vivekanandarajah >>> Jeff told me that the recent popcount built-in detection is causing >>> kernel build issues as >>> ERROR: "__popcountsi2" >>>

Re: [RFC] Fix recent popcount change is breaking

2018-07-10 Thread Jeff Law
On 07/10/2018 07:17 AM, Richard Biener wrote: > On Tue, Jul 10, 2018 at 3:06 PM Kugan Vivekanandarajah > wrote: >> >> Hi, >> >> Jeff told me that the recent popcount built-in detection is causing >> kernel build issues as >> ERROR: "__popcountsi2" >> [drivers/net/wireless/broadcom/brcm80211/brcmfm

Re: [RFC] Fix recent popcount change is breaking

2018-07-10 Thread Richard Biener
On Tue, Jul 10, 2018 at 3:27 PM Jakub Jelinek wrote: > > On Tue, Jul 10, 2018 at 03:17:48PM +0200, Richard Biener wrote: > > On Tue, Jul 10, 2018 at 3:06 PM Kugan Vivekanandarajah > > > Jeff told me that the recent popcount built-in detection is causing > > > kernel build issues as > > > ERROR: "_

Re: [RFC] Fix recent popcount change is breaking

2018-07-10 Thread Jakub Jelinek
On Tue, Jul 10, 2018 at 03:17:48PM +0200, Richard Biener wrote: > On Tue, Jul 10, 2018 at 3:06 PM Kugan Vivekanandarajah > > Jeff told me that the recent popcount built-in detection is causing > > kernel build issues as > > ERROR: "__popcountsi2" > > [drivers/net/wireless/broadcom/brcm80211/brcmfma

Re: [RFC] Fix recent popcount change is breaking

2018-07-10 Thread Richard Biener
On Tue, Jul 10, 2018 at 3:06 PM Kugan Vivekanandarajah wrote: > > Hi, > > Jeff told me that the recent popcount built-in detection is causing > kernel build issues as > ERROR: "__popcountsi2" > [drivers/net/wireless/broadcom/brcm80211/brcmfmac/brcmfmac.ko] undefined! > > I could also reproduce thi

[RFC] Fix recent popcount change is breaking

2018-07-10 Thread Kugan Vivekanandarajah
Hi, Jeff told me that the recent popcount built-in detection is causing kernel build issues as ERROR: "__popcountsi2" [drivers/net/wireless/broadcom/brcm80211/brcmfmac/brcmfmac.ko] undefined! I could also reproduce this. AFIK, we should check if the libfunc is defined while checking popcount? I