Re: [RFC] Dejagnu patch to handle multi-line directives

2017-06-20 Thread Rainer Orth
Mike Stump writes: > On Jun 10, 2017, at 12:57 AM, Tom de Vries wrote: >> >> one thing that has bothered me on a regular basis is the inability to >> spread long dejagnu directives over multiple lines. > > I'm not terribly in favor of this. I'd like to retain the ability to grep > and sed sing

Re: [RFC] Dejagnu patch to handle multi-line directives

2017-06-12 Thread Richard Sandiford
Pedro Alves writes: > On 06/12/2017 08:59 AM, Richard Sandiford wrote: >> I realise there's probably more that can go wrong with it, but how >> about instead treating unbalanced { ... } as a sign that the directive >> continues to the next line? This would allow: >> >> /* { dg-additional-options

Re: [RFC] Dejagnu patch to handle multi-line directives

2017-06-12 Thread Pedro Alves
On 06/12/2017 08:59 AM, Richard Sandiford wrote: > I realise there's probably more that can go wrong with it, but how > about instead treating unbalanced { ... } as a sign that the directive > continues to the next line? This would allow: > > /* { dg-additional-options > "-DSTACK_SIZE=[dg-e

Re: [RFC] Dejagnu patch to handle multi-line directives

2017-06-12 Thread Mike Stump
On Jun 10, 2017, at 12:57 AM, Tom de Vries wrote: > > one thing that has bothered me on a regular basis is the inability to spread > long dejagnu directives over multiple lines. I'm not terribly in favor of this. I'd like to retain the ability to grep and sed single line things. It makes exp

Re: [RFC] Dejagnu patch to handle multi-line directives

2017-06-12 Thread Richard Sandiford
Tom de Vries writes: > [ attached patch ] > > On 06/10/2017 09:57 AM, Tom de Vries wrote: >> Hi, >> >> one thing that has bothered me on a regular basis is the inability to >> spread long dejagnu directives over multiple lines. >> >> I've written a demonstrator patch (for the dejagnu sources) a

Re: [RFC] Dejagnu patch to handle multi-line directives

2017-06-10 Thread Segher Boessenkool
Hi! On Sat, Jun 10, 2017 at 10:03:04AM +0200, Tom de Vries wrote: > >/* { dg-additional-options } > >{ dg-dc "-DSTACK_SIZE=[dg-effective-target-value stack_size]" } > >{ dg-dc { target { stack_size } } } */ > >... > > > >Good idea to fix this? I like it. What is the exact semantics though

Re: [RFC] Dejagnu patch to handle multi-line directives

2017-06-10 Thread Tom de Vries
[ attached patch ] On 06/10/2017 09:57 AM, Tom de Vries wrote: Hi, one thing that has bothered me on a regular basis is the inability to spread long dejagnu directives over multiple lines. I've written a demonstrator patch (for the dejagnu sources) and tested it by splitting this 108 chars

[RFC] Dejagnu patch to handle multi-line directives

2017-06-10 Thread Tom de Vries
Hi, one thing that has bothered me on a regular basis is the inability to spread long dejagnu directives over multiple lines. I've written a demonstrator patch (for the dejagnu sources) and tested it by splitting this 108 chars line: ... /* { dg-additional-options "-DSTACK_SIZE=[dg-effective