Re: [RFC][PATCH] Postpone print of --help=* option.

2019-05-03 Thread Martin Liška
On 5/3/19 1:33 PM, Szabolcs Nagy wrote: > On 01/04/2019 13:11, Martin Liška wrote: >> Hi. >> >> Last week I was curious which warnings are disabled by default on top >> of -Wall and -Wextra. Thus I used --help=warning and noticed some discrepancy >> in between documentation and output of the --help

Re: [RFC][PATCH] Postpone print of --help=* option.

2019-05-03 Thread Szabolcs Nagy
On 01/04/2019 13:11, Martin Liška wrote: > Hi. > > Last week I was curious which warnings are disabled by default on top > of -Wall and -Wextra. Thus I used --help=warning and noticed some discrepancy > in between documentation and output of the --help option. > > I created PR89885 where I explai

Re: [PATCH] Fix build with offloading (Re: [RFC][PATCH] Postpone print of --help=* option.)

2019-05-03 Thread Richard Biener
On Fri, 3 May 2019, Jakub Jelinek wrote: > Hi! > > On Thu, May 02, 2019 at 01:04:07PM +0200, Jakub Jelinek wrote: > > Well, that doesn't answer the question. > > I was wondering why you couldn't: > > > > 2019-05-02 Jakub Jelinek > > > > * opts.h (finish_options): Remove lang_mask argumen

[PATCH] Fix build with offloading (Re: [RFC][PATCH] Postpone print of --help=* option.)

2019-05-03 Thread Jakub Jelinek
Hi! On Thu, May 02, 2019 at 01:04:07PM +0200, Jakub Jelinek wrote: > Well, that doesn't answer the question. > I was wondering why you couldn't: > > 2019-05-02 Jakub Jelinek > > * opts.h (finish_options): Remove lang_mask argument. > (print_help, help_option_argument): Declare. >

Re: [RFC][PATCH] Postpone print of --help=* option.

2019-05-02 Thread Martin Liška
On 5/2/19 1:04 PM, Jakub Jelinek wrote: > Well, that doesn't answer the question. > I was wondering why you couldn't: Ah sorry, you are right. The patch you suggested is obviously nicer than what we have currently in trunk. Feel free to install it. Martin

Re: [RFC][PATCH] Postpone print of --help=* option.

2019-05-02 Thread Jakub Jelinek
On Thu, May 02, 2019 at 12:51:05PM +0200, Martin Liška wrote: > You are right, it's guarded in #ifdef ACCEL_COMPILER > so I haven't seen the compilation error. > > > > > Any reason why you've called print_help from finish_options rather than > > decode_options after it calls finish_options? > >

Re: [RFC][PATCH] Postpone print of --help=* option.

2019-05-02 Thread Martin Liška
On 5/2/19 12:30 PM, Jakub Jelinek wrote: > On Mon, Apr 01, 2019 at 02:11:17PM +0200, Martin Liška wrote: >> 2019-04-01 Martin Liska >> >> * gcc.c (process_command): Add dummy file only >> if n_infiles == 0. >> * opts-global.c (decode_options): Pass lang_mask. >> * opts.c (pri

Re: [RFC][PATCH] Postpone print of --help=* option.

2019-05-02 Thread Jakub Jelinek
On Mon, Apr 01, 2019 at 02:11:17PM +0200, Martin Liška wrote: > 2019-04-01 Martin Liska > > * gcc.c (process_command): Add dummy file only > if n_infiles == 0. > * opts-global.c (decode_options): Pass lang_mask. > * opts.c (print_help): New function. > (finish_opti

Re: [RFC][PATCH] Postpone print of --help=* option.

2019-05-02 Thread Martin Liška
On 4/30/19 6:18 PM, Jeff Law wrote: > On 4/1/19 6:11 AM, Martin Liška wrote: >> Hi. >> >> Last week I was curious which warnings are disabled by default on top >> of -Wall and -Wextra. Thus I used --help=warning and noticed some discrepancy >> in between documentation and output of the --help optio

Re: [RFC][PATCH] Postpone print of --help=* option.

2019-04-30 Thread Jeff Law
On 4/1/19 6:11 AM, Martin Liška wrote: > Hi. > > Last week I was curious which warnings are disabled by default on top > of -Wall and -Wextra. Thus I used --help=warning and noticed some discrepancy > in between documentation and output of the --help option. > > I created PR89885 where I explaine

[RFC][PATCH] Postpone print of --help=* option.

2019-04-01 Thread Martin Liška
Hi. Last week I was curious which warnings are disabled by default on top of -Wall and -Wextra. Thus I used --help=warning and noticed some discrepancy in between documentation and output of the --help option. I created PR89885 where I explained that OPT__help_ option handling happens early. That