Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-21 Thread Richard Biener
On Fri, 21 Oct 2016, kugan wrote: > > > On 21/10/16 18:16, Richard Biener wrote: > > On Fri, 21 Oct 2016, kugan wrote: > > > > > Hi, > > > > > > On 20/10/16 23:15, Jan Hubicka wrote: > > > > > Hi Richard, > > > > > > > > > > > > > > > On 20/10/16 18:41, Richard Biener wrote: > > > > > > On T

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-21 Thread kugan
On 21/10/16 18:16, Richard Biener wrote: On Fri, 21 Oct 2016, kugan wrote: Hi, On 20/10/16 23:15, Jan Hubicka wrote: Hi Richard, On 20/10/16 18:41, Richard Biener wrote: On Thu, 20 Oct 2016, kugan wrote: On 20/10/16 01:26, Jan Hubicka wrote: Would excluding weak symbols (I believe I

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-21 Thread Richard Biener
On Fri, 21 Oct 2016, kugan wrote: > Hi, > > On 20/10/16 23:15, Jan Hubicka wrote: > > > Hi Richard, > > > > > > > > > On 20/10/16 18:41, Richard Biener wrote: > > > > On Thu, 20 Oct 2016, kugan wrote: > > > > > > > > > > > > > > > > > > > On 20/10/16 01:26, Jan Hubicka wrote: > > > > > > > >

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-20 Thread kugan
Hi, On 20/10/16 23:15, Jan Hubicka wrote: Hi Richard, On 20/10/16 18:41, Richard Biener wrote: On Thu, 20 Oct 2016, kugan wrote: On 20/10/16 01:26, Jan Hubicka wrote: Would excluding weak symbols (I believe I can check DECL_WEAK for this) good enough. Or looking for acceptable subset wou

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-20 Thread Jan Hubicka
> Hi Richard, > > > On 20/10/16 18:41, Richard Biener wrote: > >On Thu, 20 Oct 2016, kugan wrote: > > > >> > >> > >>On 20/10/16 01:26, Jan Hubicka wrote: > >Would excluding weak symbols (I believe I can check DECL_WEAK for this) > >good > >enough. Or looking for acceptable subset woul

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-20 Thread Richard Biener
On Thu, 20 Oct 2016, kugan wrote: > Hi Richard, > > > On 20/10/16 18:41, Richard Biener wrote: > > On Thu, 20 Oct 2016, kugan wrote: > > > > > > > > > > > On 20/10/16 01:26, Jan Hubicka wrote: > > > > > > Would excluding weak symbols (I believe I can check DECL_WEAK for > > > > > > this) > >

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-20 Thread kugan
Hi Richard, On 20/10/16 18:41, Richard Biener wrote: On Thu, 20 Oct 2016, kugan wrote: On 20/10/16 01:26, Jan Hubicka wrote: Would excluding weak symbols (I believe I can check DECL_WEAK for this) good enough. Or looking for acceptable subset would work? I think we should add a symtab he

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-20 Thread Richard Biener
On Thu, 20 Oct 2016, kugan wrote: > > > On 20/10/16 01:26, Jan Hubicka wrote: > > > > Would excluding weak symbols (I believe I can check DECL_WEAK for this) > > > > good > > > > enough. Or looking for acceptable subset would work? > > > > > > I think we should add a symtab helper to tell if ad

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-19 Thread kugan
On 20/10/16 01:26, Jan Hubicka wrote: Would excluding weak symbols (I believe I can check DECL_WEAK for this) good enough. Or looking for acceptable subset would work? I think we should add a symtab helper to tell if address_nonzero_p (if that doesn't aleady exist). We have node->nonzero_ad

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-19 Thread Jan Hubicka
> > Would excluding weak symbols (I believe I can check DECL_WEAK for this) good > > enough. Or looking for acceptable subset would work? > > I think we should add a symtab helper to tell if address_nonzero_p (if > that doesn't aleady exist). We have node->nonzero_address() Honza > > Richard. >

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-19 Thread Richard Biener
On Wed, 19 Oct 2016, kugan wrote: > Hi Richard, > > > On 19/10/16 19:23, Richard Biener wrote: > > On Wed, 19 Oct 2016, kugan wrote: > > > > > Hi, > > > > > > While computing jump function value range for pointer, I am wondering if > > > we > > > can assume that any tree with ADDR_EXPR will be

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-19 Thread kugan
Hi Richard, On 19/10/16 19:23, Richard Biener wrote: On Wed, 19 Oct 2016, kugan wrote: Hi, While computing jump function value range for pointer, I am wondering if we can assume that any tree with ADDR_EXPR will be nonnull. That is, in cases like: int arr[10]; foo (&arr[1]); OR struct st

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-19 Thread Richard Biener
On Wed, 19 Oct 2016, kugan wrote: > Hi, > > While computing jump function value range for pointer, I am wondering if we > can assume that any tree with ADDR_EXPR will be nonnull. > > That is, in cases like: > > int arr[10]; > foo (&arr[1]); > > OR > > struct st > { > int a; > int b; > };

[RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-18 Thread kugan
Hi, While computing jump function value range for pointer, I am wondering if we can assume that any tree with ADDR_EXPR will be nonnull. That is, in cases like: int arr[10]; foo (&arr[1]); OR struct st { int a; int b; }; struct st s2; foo (&s2.a); Attached patch tries to do this. I am