Re: [RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2015-06-17 Thread James Greenhalgh
On Thu, May 22, 2014 at 03:24:23PM +0100, Marcus Shawcroft wrote: > On 2 May 2014 13:27, Kugan wrote: > > > +2014-05-02 Kugan Vivekanandarajah > > + > > + * config/aarch64/aarch64.c (TARGET_ATOMIC_ASSIGN_EXPAND_FENV): New > > + define. > > + * config/aarch64/aarch64-protos.h

Re: [RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-05-22 Thread Marcus Shawcroft
On 2 May 2014 13:27, Kugan wrote: > +2014-05-02 Kugan Vivekanandarajah > + > + * config/aarch64/aarch64.c (TARGET_ATOMIC_ASSIGN_EXPAND_FENV): New > + define. > + * config/aarch64/aarch64-protos.h (aarch64_atomic_assign_expand_fenv): > + New function declaration. > +

Re: [RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-05-11 Thread Kugan
Ping ? Thanks, Kugan On 02/05/14 22:27, Kugan wrote: > > > On 02/05/14 20:06, Marcus Shawcroft wrote: >> On 29 April 2014 03:37, Kugan wrote: >>> >>> On 28/04/14 21:01, Ramana Radhakrishnan wrote: On 04/26/14 11:57, Kugan wrote: > Attached patch implements TARGET_ATOMIC_ASSIGN_EXPAND_F

Re: [RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-05-02 Thread Kugan
On 02/05/14 20:06, Marcus Shawcroft wrote: > On 29 April 2014 03:37, Kugan wrote: >> >> On 28/04/14 21:01, Ramana Radhakrishnan wrote: >>> On 04/26/14 11:57, Kugan wrote: Attached patch implements TARGET_ATOMIC_ASSIGN_EXPAND_FENV for AARCH64. With this, atomic test-case gcc.dg/atomic/c

Re: [RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-05-02 Thread Yufeng Zhang
On 05/02/14 10:08, Kugan wrote: diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index 347a94a..8bd13f3 100644 --- a/gcc/doc/extend.texi +++ b/gcc/doc/extend.texi @@ -9107,6 +9107,7 @@ to those machines. Generally these generate calls to specific machine instructions, but allow the comp

Re: [RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-05-02 Thread Marcus Shawcroft
On 2 May 2014 11:06, Marcus Shawcroft wrote: > Kugan, I've not looked at the respin in detail yet, but it has just > occurred to me that the sequence used here to set FPCR is > insufficient. The architecture reference manual requires that any > write to FPCR must be syncrhronized by a context sy

Re: [RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-05-02 Thread Marcus Shawcroft
On 29 April 2014 03:37, Kugan wrote: > > On 28/04/14 21:01, Ramana Radhakrishnan wrote: >> On 04/26/14 11:57, Kugan wrote: >>> Attached patch implements TARGET_ATOMIC_ASSIGN_EXPAND_FENV for AARCH64. >>> With this, atomic test-case gcc.dg/atomic/c11-atomic-exec-5.c now PASS. >>> >>> This implementa

Re: [RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-05-02 Thread Kugan
> > +2014-04-29 Kugan Vivekanandarajah > + > + * config/aarch64/aarch64.c (TARGET_ATOMIC_ASSIGN_EXPAND_FENV): New > + define. > + * config/aarch64/aarch64-protos.h (aarch64_atomic_assign_expand_fenv): > + New function declaration. > + * config/aarch64/aarch64-builtins.c (aar

Re: [RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-04-28 Thread Kugan
On 28/04/14 21:01, Ramana Radhakrishnan wrote: > On 04/26/14 11:57, Kugan wrote: >> Attached patch implements TARGET_ATOMIC_ASSIGN_EXPAND_FENV for AARCH64. >> With this, atomic test-case gcc.dg/atomic/c11-atomic-exec-5.c now PASS. >> >> This implementation is based on SPARC and i386 implementation

Re: [RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-04-28 Thread Ramana Radhakrishnan
On 04/26/14 11:57, Kugan wrote: Attached patch implements TARGET_ATOMIC_ASSIGN_EXPAND_FENV for AARCH64. With this, atomic test-case gcc.dg/atomic/c11-atomic-exec-5.c now PASS. This implementation is based on SPARC and i386 implementations. Regression tested on qemu-aarch64 for aarch64-none-linu

Re: [RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-04-28 Thread Marcus Shawcroft
Hi Kugan, Thanks for this, couple of comments inline: On 26 April 2014 11:57, Kugan wrote: > gcc/ > +2014-04-27 Kugan Vivekanandarajah > + > + * config/aarch64/aarch64.c (TARGET_ATOMIC_ASSIGN_EXPAND_FENV): New > + define. > + * config/aarch64/aarch64-builtins.c (arm_builtins

[RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-04-26 Thread Kugan
Attached patch implements TARGET_ATOMIC_ASSIGN_EXPAND_FENV for AARCH64. With this, atomic test-case gcc.dg/atomic/c11-atomic-exec-5.c now PASS. This implementation is based on SPARC and i386 implementations. Regression tested on qemu-aarch64 for aarch64-none-linux-gnu with no new regression. Is t