Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-08-12 Thread Mariam Arutunian
On Fri, Aug 2, 2024 at 2:12 PM Richard Biener wrote: > On Wed, Jul 31, 2024 at 10:15 AM Mariam Arutunian > wrote: > > > > This patch adds a new compiler pass aimed at identifying naive CRC > implementations, > > characterized by the presence of a loop calculating a CRC (polynomial > long divisi

Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-08-02 Thread Richard Biener
On Wed, Jul 31, 2024 at 10:15 AM Mariam Arutunian wrote: > > This patch adds a new compiler pass aimed at identifying naive CRC > implementations, > characterized by the presence of a loop calculating a CRC (polynomial long > division). > Upon detection of a potential CRC, the pass prints an i

[RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-07-31 Thread Mariam Arutunian
This patch adds a new compiler pass aimed at identifying naive CRC implementations, characterized by the presence of a loop calculating a CRC (polynomial long division). Upon detection of a potential CRC, the pass prints an informational message. Performs CRC optimization if optimization level

Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-06-19 Thread Mariam Arutunian
On Sun, Jun 9, 2024 at 2:00 AM Jeff Law wrote: > > > On 5/29/24 5:12 AM, Mariam Arutunian wrote: > > > > > IIRC we looked at the problem of canonicalizing the loop into a form > > where we didn't necessarily have conditional blocks, instead we had > > branchless sequences for the cond

Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-06-19 Thread Mariam Arutunian
On Sun, Jun 9, 2024 at 1:48 AM Jeff Law wrote: > > > On 6/4/24 7:41 AM, Mariam Arutunian wrote: > >/Mariam, your thoughts on whether or not those two phases could handle a > > loop with two CRC calculations inside, essentially creating two calls to > > our new builtins? / > > > > / > > / > > > >

Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-06-08 Thread Jeff Law
On 5/29/24 5:12 AM, Mariam Arutunian wrote: IIRC we looked at the problem of canonicalizing the loop into a form where we didn't necessarily have conditional blocks, instead we had branchless sequences for the conditional xor and dealing with the high bit in the crc.  My reco

Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-06-08 Thread Jeff Law
On 6/4/24 7:41 AM, Mariam Arutunian wrote: /Mariam, your thoughts on whether or not those two phases could handle a loop with two CRC calculations inside, essentially creating two calls to our new builtins? / / / It is feasible, but it would likely demand considerable effort and additiona

Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-06-04 Thread Mariam Arutunian
Sorry for the late response; somehow, I didn't receive the last few messages. >>* Am 30.05.2024 um 00:31 schrieb Jeff Law >>: *>> >>*  *>> >>>* On 5/28/24 1:01 AM, Richard Biener wrote: ** On Fri, May 24, 2024 at 10:46 AM Mariam Arutunian ** > wrote: * * This patch adds a new comp

Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-05-30 Thread Richard Biener
> Am 30.05.2024 um 00:31 schrieb Jeff Law : > >  > >> On 5/28/24 1:01 AM, Richard Biener wrote: >>> On Fri, May 24, 2024 at 10:46 AM Mariam Arutunian >>> wrote: >>> >>> This patch adds a new compiler pass aimed at identifying naive CRC >>> implementations, >>> characterized by the presence

Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-05-29 Thread Jeff Law
On 5/28/24 1:01 AM, Richard Biener wrote: On Fri, May 24, 2024 at 10:46 AM Mariam Arutunian wrote: This patch adds a new compiler pass aimed at identifying naive CRC implementations, characterized by the presence of a loop calculating a CRC (polynomial long division). Upon detection of a

Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-05-29 Thread David Malcolm
On Fri, 2024-05-24 at 12:42 +0400, Mariam Arutunian wrote: > This patch adds a new compiler pass aimed at identifying naive CRC > implementations, > characterized by the presence of a loop calculating a CRC (polynomial > long > division). > Upon detection of a potential CRC, the pass prints an info

Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-05-29 Thread Mariam Arutunian
On Tue, May 28, 2024 at 8:20 AM Jeff Law wrote: > > > On 5/24/24 2:42 AM, Mariam Arutunian wrote: > > This patch adds a new compiler pass aimed at identifying naive CRC > > implementations, > > characterized by the presence of a loop calculating a CRC (polynomial > > long division). > > Upon dete

Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-05-28 Thread Richard Biener
On Fri, May 24, 2024 at 10:46 AM Mariam Arutunian wrote: > > This patch adds a new compiler pass aimed at identifying naive CRC > implementations, > characterized by the presence of a loop calculating a CRC (polynomial long > division). > Upon detection of a potential CRC, the pass prints an inf

Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-05-27 Thread Jeff Law
On 5/24/24 2:42 AM, Mariam Arutunian wrote: This patch adds a new compiler pass aimed at identifying naive CRC implementations, characterized by the presence of a loop calculating a CRC (polynomial long division). Upon detection of a potential CRC, the pass prints an informational message.

[RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-05-24 Thread Mariam Arutunian
This patch adds a new compiler pass aimed at identifying naive CRC implementations, characterized by the presence of a loop calculating a CRC (polynomial long division). Upon detection of a potential CRC, the pass prints an informational message. Performs CRC optimization if optimization level is