Re: [RFC/PATCH] vect: Recog mul_highpart pattern

On Thu, Jul 15, 2021 at 09:40:52AM +0800, Kewen.Lin wrote: > on 2021/7/15 上午3:32, Segher Boessenkool wrote: > > The normal rule is you cannot go over 80. It is perfectly fine to have > > shorter lines, certainly if that is nice for some other reason, so > > automatically (by some tool) changing th

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

on 2021/7/15 上午3:32, Segher Boessenkool wrote: > On Wed, Jul 14, 2021 at 12:32:24PM +0100, Richard Sandiford wrote: >> TBH, 79 vs. 80 isn't normally something I'd worry about when reviewing >> new code. But I know in the past people have asked for 79 to be used >> for the “end+1” reason, so I don'

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

on 2021/7/14 下午7:32, Richard Sandiford wrote: > "Kewen.Lin" writes: >> Hi Richard, >> >> on 2021/7/14 下午4:38, Richard Sandiford wrote: >>> "Kewen.Lin" writes: gcc/ChangeLog: * internal-fn.c (first_commutative_argument): Add info for IFN_MULH. * internal-fn.def (IFN_MULH)

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

On Wed, Jul 14, 2021 at 12:32:24PM +0100, Richard Sandiford wrote: > TBH, 79 vs. 80 isn't normally something I'd worry about when reviewing > new code. But I know in the past people have asked for 79 to be used > for the “end+1” reason, so I don't think we should “fix” existing code > that honours

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

"Kewen.Lin" writes: > Hi Richard, > > on 2021/7/14 下午4:38, Richard Sandiford wrote: >> "Kewen.Lin" writes: >>> gcc/ChangeLog: >>> >>> * internal-fn.c (first_commutative_argument): Add info for IFN_MULH. >>> * internal-fn.def (IFN_MULH): New internal function. >>> * tree-vect-patterns.

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

Hi Richard, on 2021/7/14 下午4:38, Richard Sandiford wrote: > "Kewen.Lin" writes: >> gcc/ChangeLog: >> >> * internal-fn.c (first_commutative_argument): Add info for IFN_MULH. >> * internal-fn.def (IFN_MULH): New internal function. >> * tree-vect-patterns.c (vect_recog_mulhs_pattern):

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

"Kewen.Lin" writes: > gcc/ChangeLog: > > * internal-fn.c (first_commutative_argument): Add info for IFN_MULH. > * internal-fn.def (IFN_MULH): New internal function. > * tree-vect-patterns.c (vect_recog_mulhs_pattern): Add support to > recog normal multiply highpart as IFN_M

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

on 2021/7/14 下午2:38, Richard Biener wrote: > On Tue, Jul 13, 2021 at 4:59 PM Kewen.Lin wrote: >> >> on 2021/7/13 下午8:42, Richard Biener wrote: >>> On Tue, Jul 13, 2021 at 12:25 PM Kewen.Lin wrote: Hi Richi, Thanks for the comments! on 2021/7/13 下午5:35, Richard Biener

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

On Tue, Jul 13, 2021 at 4:59 PM Kewen.Lin wrote: > > on 2021/7/13 下午8:42, Richard Biener wrote: > > On Tue, Jul 13, 2021 at 12:25 PM Kewen.Lin wrote: > >> > >> Hi Richi, > >> > >> Thanks for the comments! > >> > >> on 2021/7/13 下午5:35, Richard Biener wrote: > >>> On Tue, Jul 13, 2021 at 10:53 AM

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

on 2021/7/13 下午8:42, Richard Biener wrote: > On Tue, Jul 13, 2021 at 12:25 PM Kewen.Lin wrote: >> >> Hi Richi, >> >> Thanks for the comments! >> >> on 2021/7/13 下午5:35, Richard Biener wrote: >>> On Tue, Jul 13, 2021 at 10:53 AM Kewen.Lin wrote: Hi, When I added the support for

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

On Tue, Jul 13, 2021 at 12:25 PM Kewen.Lin wrote: > > Hi Richi, > > Thanks for the comments! > > on 2021/7/13 下午5:35, Richard Biener wrote: > > On Tue, Jul 13, 2021 at 10:53 AM Kewen.Lin wrote: > >> > >> Hi, > >> > >> When I added the support for Power10 newly introduced multiply > >> highpart in

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

Hi Richi, Thanks for the comments! on 2021/7/13 下午5:35, Richard Biener wrote: > On Tue, Jul 13, 2021 at 10:53 AM Kewen.Lin wrote: >> >> Hi, >> >> When I added the support for Power10 newly introduced multiply >> highpart instrutions, I noticed that currently vectorizer >> doesn't try to vectoriz

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

Richard Biener writes: > On Tue, Jul 13, 2021 at 11:40 AM Richard Sandiford > wrote: >> >> Richard Biener writes: >> > On Tue, Jul 13, 2021 at 10:53 AM Kewen.Lin wrote: >> >> >> >> Hi, >> >> >> >> When I added the support for Power10 newly introduced multiply >> >> highpart instrutions, I notic

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

On Tue, Jul 13, 2021 at 11:40 AM Richard Sandiford wrote: > > Richard Biener writes: > > On Tue, Jul 13, 2021 at 10:53 AM Kewen.Lin wrote: > >> > >> Hi, > >> > >> When I added the support for Power10 newly introduced multiply > >> highpart instrutions, I noticed that currently vectorizer > >> do

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

Richard Biener writes: > On Tue, Jul 13, 2021 at 10:53 AM Kewen.Lin wrote: >> >> Hi, >> >> When I added the support for Power10 newly introduced multiply >> highpart instrutions, I noticed that currently vectorizer >> doesn't try to vectorize multiply highpart pattern, I hope >> this isn't intent

Re: [RFC/PATCH] vect: Recog mul_highpart pattern

On Tue, Jul 13, 2021 at 10:53 AM Kewen.Lin wrote: > > Hi, > > When I added the support for Power10 newly introduced multiply > highpart instrutions, I noticed that currently vectorizer > doesn't try to vectorize multiply highpart pattern, I hope > this isn't intentional? > > This patch is to exten

[RFC/PATCH] vect: Recog mul_highpart pattern

Hi, When I added the support for Power10 newly introduced multiply highpart instrutions, I noticed that currently vectorizer doesn't try to vectorize multiply highpart pattern, I hope this isn't intentional? This patch is to extend the existing pattern mulhs handlings to cover multiply highpart.