Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-13 Thread Jeff Law via Gcc-patches
On 6/13/2021 10:02 AM, Aldy Hernandez via Gcc-patches wrote: On Mon, Jun 7, 2021 at 4:32 PM Andrew MacLeod wrote: Aldy, I think this means we can use global information in the get_global query for ranger if "cfun->after_inlining" is true, otherwise do what we currently do. Tested on x86-64

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-13 Thread Aldy Hernandez via Gcc-patches
On Mon, Jun 7, 2021 at 4:32 PM Andrew MacLeod wrote: > Aldy, I think this means we can use global information in the get_global > query for ranger if "cfun->after_inlining" is true, otherwise do what we > currently do. Tested on x86-64 Linux. OK for trunk? Aldy From 914810565183ad2cdac82ed5bab

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-07 Thread Andrew MacLeod via Gcc-patches
On 6/7/21 9:45 AM, Richard Biener wrote: On Mon, Jun 7, 2021 at 3:37 PM Andrew MacLeod wrote: On 6/7/21 3:25 AM, Richard Biener wrote: On Wed, Jun 2, 2021 at 2:53 PM Andrew MacLeod wrote: On 6/2/21 7:52 AM, Richard Biener wrote: On Wed, Jun 2, 2021 at 12:34 PM Aldy Hernandez via Gcc-patches

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 3:37 PM Andrew MacLeod wrote: > > On 6/7/21 3:25 AM, Richard Biener wrote: > > On Wed, Jun 2, 2021 at 2:53 PM Andrew MacLeod wrote: > >> On 6/2/21 7:52 AM, Richard Biener wrote: > >>> On Wed, Jun 2, 2021 at 12:34 PM Aldy Hernandez via Gcc-patches > >>> wrote: > We've

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-07 Thread Andrew MacLeod via Gcc-patches
On 6/7/21 3:25 AM, Richard Biener wrote: On Wed, Jun 2, 2021 at 2:53 PM Andrew MacLeod wrote: On 6/2/21 7:52 AM, Richard Biener wrote: On Wed, Jun 2, 2021 at 12:34 PM Aldy Hernandez via Gcc-patches wrote: We've been having "issues" in our branch when exporting to the global space ranges that

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-07 Thread Aldy Hernandez via Gcc-patches
On Mon, Jun 7, 2021 at 9:30 AM Richard Biener wrote: > > On Wed, Jun 2, 2021 at 4:53 PM Aldy Hernandez wrote: > > > > > > > > On 6/2/21 1:52 PM, Richard Biener wrote: > > > On Wed, Jun 2, 2021 at 12:34 PM Aldy Hernandez via Gcc-patches > > > wrote: > > > > > the case where this only happens aft

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-07 Thread Richard Biener via Gcc-patches
On Wed, Jun 2, 2021 at 4:53 PM Aldy Hernandez wrote: > > > > On 6/2/21 1:52 PM, Richard Biener wrote: > > On Wed, Jun 2, 2021 at 12:34 PM Aldy Hernandez via Gcc-patches > > wrote: > > > But the whole point of all this singing and dancing is not to make > > warnings but to be able to implement ass

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-07 Thread Richard Biener via Gcc-patches
On Wed, Jun 2, 2021 at 2:53 PM Andrew MacLeod wrote: > > On 6/2/21 7:52 AM, Richard Biener wrote: > > On Wed, Jun 2, 2021 at 12:34 PM Aldy Hernandez via Gcc-patches > > wrote: > >> We've been having "issues" in our branch when exporting to the global > >> space ranges that take into account previ

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-03 Thread Andrew MacLeod via Gcc-patches
On 6/2/21 6:32 AM, Aldy Hernandez wrote: We've been having "issues" in our branch when exporting to the global space ranges that take into account previously known ranges (SSA_NAME_RANGE_INFO, etc).  For the longest time we had the export feature turned off because it had the potential of remov

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-02 Thread Aldy Hernandez via Gcc-patches
On 6/2/21 1:52 PM, Richard Biener wrote: On Wed, Jun 2, 2021 at 12:34 PM Aldy Hernandez via Gcc-patches wrote: But the whole point of all this singing and dancing is not to make warnings but to be able to implement assert (); or assume (); that will result in no code but optimization based

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-02 Thread Andrew MacLeod via Gcc-patches
On 6/2/21 7:52 AM, Richard Biener wrote: On Wed, Jun 2, 2021 at 12:34 PM Aldy Hernandez via Gcc-patches wrote: We've been having "issues" in our branch when exporting to the global space ranges that take into account previously known ranges (SSA_NAME_RANGE_INFO, etc). For the longest time we h

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-02 Thread Richard Biener via Gcc-patches
On Wed, Jun 2, 2021 at 12:34 PM Aldy Hernandez via Gcc-patches wrote: > > We've been having "issues" in our branch when exporting to the global > space ranges that take into account previously known ranges > (SSA_NAME_RANGE_INFO, etc). For the longest time we had the export > feature turned off b

[RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-02 Thread Aldy Hernandez via Gcc-patches
We've been having "issues" in our branch when exporting to the global space ranges that take into account previously known ranges (SSA_NAME_RANGE_INFO, etc). For the longest time we had the export feature turned off because it had the potential of removing __builtin_unreachable code early in t