Re: [RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-02 Thread Kewen.Lin via Gcc-patches
Hi Segher, Thanks for the comments! on 2021/9/3 上午1:44, Segher Boessenkool wrote: > Hi! > > On Wed, Sep 01, 2021 at 03:02:22PM +0800, Kewen.Lin wrote: >> It introduces two target hooks need_ipa_fn_target_info and >> update_ipa_fn_target_info. The former allows target to do >> some previous chec

Re: [RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-02 Thread Segher Boessenkool
Hi! On Wed, Sep 01, 2021 at 03:02:22PM +0800, Kewen.Lin wrote: > It introduces two target hooks need_ipa_fn_target_info and > update_ipa_fn_target_info. The former allows target to do > some previous check and decides to collect target specific > information for this function or not. For some sp

Re: [RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-02 Thread Richard Biener via Gcc-patches
On Thu, Sep 2, 2021 at 3:11 PM Kewen.Lin wrote: > > on 2021/9/2 下午7:51, Richard Biener wrote: > > On Thu, Sep 2, 2021 at 1:13 PM Kewen.Lin wrote: > >> > >> Hi Richi, > >> > >> Thanks for the comments! > >> > >> on 2021/9/2 下午5:25, Richard Biener wrote: > >>> On Wed, Sep 1, 2021 at 9:02 AM Kewen.L

Re: [RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-02 Thread Kewen.Lin via Gcc-patches
on 2021/9/2 下午7:51, Richard Biener wrote: > On Thu, Sep 2, 2021 at 1:13 PM Kewen.Lin wrote: >> >> Hi Richi, >> >> Thanks for the comments! >> >> on 2021/9/2 下午5:25, Richard Biener wrote: >>> On Wed, Sep 1, 2021 at 9:02 AM Kewen.Lin wrote: Hi! Power ISA 2.07 (Power8) introduces

Re: [RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-02 Thread Richard Biener via Gcc-patches
On Thu, Sep 2, 2021 at 1:13 PM Kewen.Lin wrote: > > Hi Richi, > > Thanks for the comments! > > on 2021/9/2 下午5:25, Richard Biener wrote: > > On Wed, Sep 1, 2021 at 9:02 AM Kewen.Lin wrote: > >> > >> Hi! > >> > >> Power ISA 2.07 (Power8) introduces transactional memory feature > >> but ISA3.1 (Pow

Re: [RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-02 Thread Kewen.Lin via Gcc-patches
Hi Richi, Thanks for the comments! on 2021/9/2 下午5:25, Richard Biener wrote: > On Wed, Sep 1, 2021 at 9:02 AM Kewen.Lin wrote: >> >> Hi! >> >> Power ISA 2.07 (Power8) introduces transactional memory feature >> but ISA3.1 (Power10) removes it. It exposes one troublesome >> issue as PR102059 show

Re: [RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-02 Thread Richard Biener via Gcc-patches
On Wed, Sep 1, 2021 at 9:02 AM Kewen.Lin wrote: > > Hi! > > Power ISA 2.07 (Power8) introduces transactional memory feature > but ISA3.1 (Power10) removes it. It exposes one troublesome > issue as PR102059 shows. Users define some function with > target pragma cpu=power10 then it calls one funct

[RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-01 Thread Kewen.Lin via Gcc-patches
Hi! Power ISA 2.07 (Power8) introduces transactional memory feature but ISA3.1 (Power10) removes it. It exposes one troublesome issue as PR102059 shows. Users define some function with target pragma cpu=power10 then it calls one function with attribute always_inline which inherits command line o