Re: [RFC, PATCH 3/n] IPA C++ refactoring

2014-08-02 Thread Martin Liška
On 08/01/2014 08:19 PM, Jeff Law wrote: > On 08/01/14 05:35, Martin Liška wrote: >> 2014-07-31 Martin Liska >> >> * cgraph.h (cgraph_node_set, varpool_node_set): Removed structs and all >> related functions that manipulated these data structures. >> (cgraph_new_nodes): vec replaces cg

Re: [RFC, PATCH 3/n] IPA C++ refactoring

2014-08-01 Thread Jeff Law
On 08/01/14 05:35, Martin Liška wrote: 2014-07-31 Martin Liska * cgraph.h (cgraph_node_set, varpool_node_set): Removed structs and all related functions that manipulated these data structures. (cgraph_new_nodes): vec replaces cgraph_node_set. * cgraphunit.c (cgra

Re: [RFC, PATCH 3/n] IPA C++ refactoring

2014-08-01 Thread Martin Liška
Hi, thank you for your comment. Fixed. Martin On 08/01/2014 01:46 PM, Jakub Jelinek wrote: > Hi! > > Just a random comment: > > On Fri, Aug 01, 2014 at 01:35:47PM +0200, Martin Liška wrote: >> @@ -357,8 +356,8 @@ cgraph_process_new_functions (void) >>break; >> } >> } >> - fr

Re: [RFC, PATCH 3/n] IPA C++ refactoring

2014-08-01 Thread Jakub Jelinek
Hi! Just a random comment: On Fri, Aug 01, 2014 at 01:35:47PM +0200, Martin Liška wrote: > @@ -357,8 +356,8 @@ cgraph_process_new_functions (void) > break; > } > } > - free_cgraph_node_set (cgraph_new_nodes); > - cgraph_new_nodes = NULL; > + > +cgraph_new_nodes.release ()

Re: [RFC, PATCH 3/n] IPA C++ refactoring

2014-08-01 Thread Martin Liška
On 08/01/2014 02:34 AM, Trevor Saunders wrote: >> +++ b/gcc/cgraph.h >> @@ -27,6 +27,7 @@ along with GCC; see the file COPYING3. If not see >> #include "basic-block.h" >> #include "function.h" >> #include "ipa-ref.h" >> +#include "indexed-set.h" > you don't actually use that here so why are yo

Re: [RFC, PATCH 3/n] IPA C++ refactoring

2014-07-31 Thread Trevor Saunders
> +++ b/gcc/cgraph.h > @@ -27,6 +27,7 @@ along with GCC; see the file COPYING3. If not see > #include "basic-block.h" > #include "function.h" > #include "ipa-ref.h" > +#include "indexed-set.h" you don't actually use that here so why are you including it? > +++ b/gcc/cgraphunit.c > @@ -211,11

Re: [RFC, PATCH 3/n] IPA C++ refactoring

2014-07-31 Thread Jan Hubicka
> Hello, >in the following patch, I would like to introduce a new template class > (indexed_set) that can replace many cgraph_node_set and varpool_node_set > related functions. > > Bootstrapped on x86_64-pc-linux-gnu, no regression observed. > > Thank you, > Martin > 2014-07-31 Martin Lis

[RFC, PATCH 3/n] IPA C++ refactoring

2014-07-31 Thread Martin Liška
Hello, in the following patch, I would like to introduce a new template class (indexed_set) that can replace many cgraph_node_set and varpool_node_set related functions. Bootstrapped on x86_64-pc-linux-gnu, no regression observed. Thank you, Martin 2014-07-31 Martin Liska * cgrap