Re: [RFA 2/n] Don't lift loads above register using jumps in postreload-gcse.c

2012-09-25 Thread Steven Bosscher
On Tue, Sep 25, 2012 at 9:12 PM, Matthew Gretton-Dann wrote: >> No, I mean using the onlyjump_p predicate. > > Again sorry for the delay. Attached is an updated patch using the onlyjump_p > predicate as suggested by Steven. + if (onlyjump_p (BB_END (pred->src))) Eh, don't you want (!onlyju

Re: [RFA 2/n] Don't lift loads above register using jumps in postreload-gcse.c

2012-09-25 Thread Matthew Gretton-Dann
On Wednesday 05 September 2012 17:40:23 Steven Bosscher wrote: > On Wed, Sep 5, 2012 at 3:18 PM, Matthew Gretton-Dann > > wrote: > > On 5 September 2012 13:45, Richard Earnshaw wrote: > >> On 05/09/12 13:02, Steven Bosscher wrote: > >>> On Wed, Sep 5, 2012 at 1:42 PM, Matthew Gretton-Dann wrote:

Re: [RFA 2/n] Don't lift loads above register using jumps in postreload-gcse.c

2012-09-05 Thread Steven Bosscher
On Wed, Sep 5, 2012 at 3:18 PM, Matthew Gretton-Dann wrote: > On 5 September 2012 13:45, Richard Earnshaw wrote: >> On 05/09/12 13:02, Steven Bosscher wrote: >>> On Wed, Sep 5, 2012 at 1:42 PM, Matthew Gretton-Dann wrote: Whilst this fix works for this particular case I am not sure it is the

Re: [RFA 2/n] Don't lift loads above register using jumps in postreload-gcse.c

2012-09-05 Thread Matthew Gretton-Dann
On 5 September 2012 13:45, Richard Earnshaw wrote: > On 05/09/12 13:02, Steven Bosscher wrote: >> On Wed, Sep 5, 2012 at 1:42 PM, Matthew Gretton-Dann wrote: >>> Whilst this fix works for this particular case I am not sure it is the >>> best fix for the general issue, and so if others have a bette

Re: [RFA 2/n] Don't lift loads above register using jumps in postreload-gcse.c

2012-09-05 Thread Richard Earnshaw
On 05/09/12 13:02, Steven Bosscher wrote: > On Wed, Sep 5, 2012 at 1:42 PM, Matthew Gretton-Dann wrote: >> Whilst this fix works for this particular case I am not sure it is the >> best fix for the general issue, and so if others have a better idea how >> to fix this I would be very happy. > > pos

Re: [RFA 2/n] Don't lift loads above register using jumps in postreload-gcse.c

2012-09-05 Thread Steven Bosscher
On Wed, Sep 5, 2012 at 1:42 PM, Matthew Gretton-Dann wrote: > Whilst this fix works for this particular case I am not sure it is the > best fix for the general issue, and so if others have a better idea how > to fix this I would be very happy. postreload-gcse.c is broken in "interesting" ways. Loo

[RFA 2/n] Don't lift loads above register using jumps in postreload-gcse.c

2012-09-05 Thread Matthew Gretton-Dann
All, When implementing ARM/Thumb support for -freorder-blocks-and-partition I encountered the following silent code generation fault. Given the following CFG: | | 93 97 | | (FALLTHRU)(CROSSING) \ / \\ /---/