Re: [RFA] Restore combine.c split point for multiply-accumulate instructions

2015-05-21 Thread Jeff Law
On 05/21/2015 07:40 AM, Segher Boessenkool wrote: On Wed, May 20, 2015 at 11:38:44PM -0600, Jeff Law wrote: I've also verified this is one of the changes ultimately necessary to resolve the code generation regressions caused by Venkat's combine.c change on the PA across my 300+ testfiles for a P

Re: [RFA] Restore combine.c split point for multiply-accumulate instructions

2015-05-21 Thread Segher Boessenkool
On Wed, May 20, 2015 at 11:38:44PM -0600, Jeff Law wrote: > I've also verified this is one of the changes ultimately necessary to > resolve the code generation regressions caused by Venkat's combine.c > change on the PA across my 300+ testfiles for a PA cross compiler. How much does it help, do

Re: [RFA] Restore combine.c split point for multiply-accumulate instructions

2015-05-21 Thread Richard Biener
On Thu, May 21, 2015 at 7:38 AM, Jeff Law wrote: > > find_split_point will tend to favor splitting complex insns in such a way as > to encourage multiply-add insns. It does this by splitting an > unrecognizable insn at the (plus (mult)). > > Now that many MULTs are canonicalized as ASHIFT, that c

[RFA] Restore combine.c split point for multiply-accumulate instructions

2015-05-20 Thread Jeff Law
find_split_point will tend to favor splitting complex insns in such a way as to encourage multiply-add insns. It does this by splitting an unrecognizable insn at the (plus (mult)). Now that many MULTs are canonicalized as ASHIFT, that code to prefer the multiply-add is no longer triggering