Re: [RFA][PATCH] Adding missing calls to bitmap_clear

2016-04-29 Thread Richard Biener
On Thu, Apr 28, 2016 at 9:35 PM, Jeff Law wrote: > On 03/22/2016 03:37 AM, Richard Biener wrote: >> >> On Mon, Mar 21, 2016 at 9:32 PM, Jeff Law wrote: >>> >>> On 03/21/2016 01:10 PM, Bernd Schmidt wrote: On 03/21/2016 08:06 PM, Jeff Law wrote: > > > > As noted last

Re: [RFA][PATCH] Adding missing calls to bitmap_clear

2016-04-28 Thread Jeff Law
On 03/22/2016 03:37 AM, Richard Biener wrote: On Mon, Mar 21, 2016 at 9:32 PM, Jeff Law wrote: On 03/21/2016 01:10 PM, Bernd Schmidt wrote: On 03/21/2016 08:06 PM, Jeff Law wrote: As noted last week, find_removable_extensions initializes several bitmaps, but doesn't clear them. This is no

Re: [RFA][PATCH] Adding missing calls to bitmap_clear

2016-03-22 Thread Richard Biener
On Mon, Mar 21, 2016 at 9:32 PM, Jeff Law wrote: > On 03/21/2016 01:10 PM, Bernd Schmidt wrote: >> >> On 03/21/2016 08:06 PM, Jeff Law wrote: >>> >>> >>> As noted last week, find_removable_extensions initializes several >>> bitmaps, but doesn't clear them. >>> >>> This is not strictly a leak as th

Re: [RFA][PATCH] Adding missing calls to bitmap_clear

2016-03-21 Thread Jeff Law
On 03/21/2016 01:10 PM, Bernd Schmidt wrote: On 03/21/2016 08:06 PM, Jeff Law wrote: As noted last week, find_removable_extensions initializes several bitmaps, but doesn't clear them. This is not strictly a leak as the GC system should find dead data, but it's better to go ahead and clear the

Re: [RFA][PATCH] Adding missing calls to bitmap_clear

2016-03-21 Thread Bernd Schmidt
On 03/21/2016 08:06 PM, Jeff Law wrote: As noted last week, find_removable_extensions initializes several bitmaps, but doesn't clear them. This is not strictly a leak as the GC system should find dead data, but it's better to go ahead and clear the bitmaps. That releases the elements back to t

[RFA][PATCH] Adding missing calls to bitmap_clear

2016-03-21 Thread Jeff Law
As noted last week, find_removable_extensions initializes several bitmaps, but doesn't clear them. This is not strictly a leak as the GC system should find dead data, but it's better to go ahead and clear the bitmaps. That releases the elements back to the cache and presumably makes things