> Looks OK to me.
Thanks, DJ. I've just checked the patch in on the GCC side.
I will push it on the src/GDB CVS momentarily.
--
Joel
On Jun 15 20:27, Eli Zaretskii wrote:
> > Date: Wed, 15 Jun 2011 10:22:36 +0200
> > From: Corinna Vinschen <...>
> > Talking about case-insensitive comparison, the filename_cmp and
> > filename_ncmp functions don't work for multibyte codesets, only for
> > singlebyte codesets. Given that UTF-8 is
> Date: Wed, 15 Jun 2011 06:59:11 -0400
> From: Robert Dewar
> CC: vinsc...@redhat.com, d...@redhat.com, pins...@gmail.com,
> brobec...@adacore.com, gcc-patches@gcc.gnu.org, gdb-patc...@sourceware.org
>
> > or some piece of code in the toolchain arbitrarily changed the
> > case of a filename.
> Date: Wed, 15 Jun 2011 10:22:36 +0200
> From: Corinna Vinschen
> Cc: Andrew Pinski , brobec...@adacore.com,
> gcc-patches@gcc.gnu.org, gdb-patc...@sourceware.org
>
> Talking about case-insensitive comparison, the filename_cmp and
> filename_ncmp functions don't work for multibyte codesets, onl
On 6/15/2011 5:58 AM, Mark Kettenis wrote:
Over my dead body. On a proper operating system filenames are
case-sensitive. Your suggestion would create spurious matches.
Yes, we all know that Unix systems chose case sensitive, and
are happy to have files differing only by case in the same
dire
On Jun 15 10:45, Joseph S. Myers wrote:
> On Wed, 15 Jun 2011, Corinna Vinschen wrote:
>
> > these functions be replaced with multibyte-aware versions? Along the
> > same lines, the entire set of safe-ctype functions only work for ASCII
> > and EBCDIC...
>
> That's the whole point of safe-ctype:
On Wednesday 15 June 2011 11:44:19, Corinna Vinschen wrote:
> Indeed. Probably the case sensitivity should not be hardcoded in a
> low-level function at all. The application should decide if it wants
> case-sensitive or case-insensitive filename comparison. This way,
> the comparison could be ba
On Wed, 15 Jun 2011, Corinna Vinschen wrote:
> these functions be replaced with multibyte-aware versions? Along the
> same lines, the entire set of safe-ctype functions only work for ASCII
> and EBCDIC...
That's the whole point of safe-ctype: that code that is processing things
such as C source
On Jun 15 11:58, Mark Kettenis wrote:
> > Date: Wed, 15 Jun 2011 10:22:36 +0200
> > From: Corinna Vinschen <...>
Please do not quote my email address in the body of your message.
Thank you.
> > IMHO it's actually a pity that the filename comparison behaves differently
> > on different systems. I
> Date: Wed, 15 Jun 2011 10:22:36 +0200
> From: Corinna Vinschen
>
> On Jun 14 18:01, DJ Delorie wrote:
> >
> > > This is wrong as not all FSs are case insensitive. In fact HFS+ can
> > > be case sensitive too. I think you need better check than just
> > > saying all Darwin is case insensitive
On Jun 14 18:01, DJ Delorie wrote:
>
> > This is wrong as not all FSs are case insensitive. In fact HFS+ can
> > be case sensitive too. I think you need better check than just
> > saying all Darwin is case insensitive. This is just like using
> > FAT32 on Linux. In fact I think HAVE_DOS_BASED_
> There's a difference between case preserving and case sensitive,
> though, and we really don't have a portable way to detect
> case-sensitivity on a per-directory basis, sow how can we do better?
That's roughly my thoughts on this issue. It's true that this property
is not an OS property, and we
On Jun 15, 2011, at 12:01 AM, DJ Delorie wrote:
>
>> This is wrong as not all FSs are case insensitive. In fact HFS+ can
>> be case sensitive too. I think you need better check than just
>> saying all Darwin is case insensitive. This is just like using
>> FAT32 on Linux. In fact I think HAVE
> This is wrong as not all FSs are case insensitive. In fact HFS+ can
> be case sensitive too. I think you need better check than just
> saying all Darwin is case insensitive. This is just like using
> FAT32 on Linux. In fact I think HAVE_DOS_BASED_FILE_SYSTEM is
> incorrect also for NTFS as i
On Tue, Jun 14, 2011 at 2:33 PM, Joel Brobecker wrote:
> Hello,
>
> HFS+, the FS on Darwin, is case insensitive. So this patch adjusts
> filename_cmp.c to ignore the casing when comparing filenames on Darwin.
This is wrong as not all FSs are case insensitive. In fact HFS+ can
be case sensitive t
Looks OK to me.
Hello,
HFS+, the FS on Darwin, is case insensitive. So this patch adjusts
filename_cmp.c to ignore the casing when comparing filenames on Darwin.
This is visible in GDB when trying to break on a file whose name
is, say 'Mixed_Case.adb', but was compiled using 'mixed_case.adb'
as the filename. In
17 matches
Mail list logo
