On Tue, 30 Jun 2015, James Greenhalgh wrote:
>
> On Fri, Jun 26, 2015 at 06:10:00PM +0100, Jakub Jelinek wrote:
> > On Fri, Jun 26, 2015 at 06:03:34PM +0100, James Greenhalgh wrote:
> > > --- /dev/null
> > > +++ b/gcc/testsuite/g++.dg/pr66119.C
> >
> > I think generally testcases shouldn't be add
On Fri, Jun 26, 2015 at 06:10:00PM +0100, Jakub Jelinek wrote:
> On Fri, Jun 26, 2015 at 06:03:34PM +0100, James Greenhalgh wrote:
> > --- /dev/null
> > +++ b/gcc/testsuite/g++.dg/pr66119.C
>
> I think generally testcases shouldn't be added into g++.dg/ directly,
> but subdirectories. So g++.dg/o
On Fri, Jun 26, 2015 at 06:03:34PM +0100, James Greenhalgh wrote:
> --- /dev/null
> +++ b/gcc/testsuite/g++.dg/pr66119.C
I think generally testcases shouldn't be added into g++.dg/ directly,
but subdirectories. So g++.dg/opt/ ?
> @@ -0,0 +1,69 @@
> +/* PR66119 - MOVE_RATIO is not constant in a c
On Thu, Jun 25, 2015 at 05:05:22AM +0100, Jeff Law wrote:
> On 06/23/2015 09:42 AM, James Greenhalgh wrote:
> >
> > On Tue, Jun 23, 2015 at 09:52:01AM +0100, Jakub Jelinek wrote:
> >> On Tue, Jun 23, 2015 at 09:18:52AM +0100, James Greenhalgh wrote:
> >>> This patch fixes the issue by always calli
On 06/23/2015 09:42 AM, James Greenhalgh wrote:
On Tue, Jun 23, 2015 at 09:52:01AM +0100, Jakub Jelinek wrote:
On Tue, Jun 23, 2015 at 09:18:52AM +0100, James Greenhalgh wrote:
This patch fixes the issue by always calling get_move_ratio in the SRA
code, ensuring that an up-to-date value is use
On Tue, Jun 23, 2015 at 09:52:01AM +0100, Jakub Jelinek wrote:
> On Tue, Jun 23, 2015 at 09:18:52AM +0100, James Greenhalgh wrote:
> > This patch fixes the issue by always calling get_move_ratio in the SRA
> > code, ensuring that an up-to-date value is used.
> >
> > Unfortunately, this means we ha
On Tue, Jun 23, 2015 at 09:18:52AM +0100, James Greenhalgh wrote:
> This patch fixes the issue by always calling get_move_ratio in the SRA
> code, ensuring that an up-to-date value is used.
>
> Unfortunately, this means we have to use 0 as a sentinel value for
> the parameter - indicating no user
Hi,
The problem in PR66119 is that we assume MOVE_RATIO will be constant
for a compilation run, such that we only need to read it once at compiler
startup if we want to set up defaults for
--param sra-max-scalarization-size-Osize and
--param sra-max-scalarization-size-Osize.
This assumption is f
