Re: [Patch ARM] Fix PR51819.

2012-04-16 Thread Ulrich Weigand
Ramana Radhakrishnan wrote: > This looks OK to me. Looking at the ISA documents and the variants of > the vldn instructions your summary is correct. The alignment specifier > should not be greater than the memory size being transferred and > checking this in this form is OK . Thanks, Ramana! I'v

Re: [Patch ARM] Fix PR51819.

2012-04-16 Thread Ramana Radhakrishnan
Hi Uli, Apologies for the delayed response. > > Shouldn't the check be implemented along the following lines? > >        if (memsize == 32 && (align % 32) == 0) >          align_bits = 256; >        else if ((memsize == 16 || memsize == 32) && (align % 16) == 0) >          align_bits = 128; >    

Re: [Patch ARM] Fix PR51819.

2012-03-31 Thread Ulrich Weigand
Ramana Radhakrishnan wrote: > PR51819 is a case where we were actually putting out alignment hints > for the wrong memory size. The attached patch corrects this and > another latent issue that I spotted. Your patch did: /* Only certain alignment specifiers are supported by the hardware.

[Patch ARM] Fix PR51819.

2012-01-20 Thread Ramana Radhakrishnan
Hi, PR51819 is a case where we were actually putting out alignment hints for the wrong memory size. The attached patch corrects this and another latent issue that I spotted. Committed after testing on arm-linux-gnueabi with Neon configurations. cheers Ramana 2012-01-20 Ramana Radhakrishnan