Re: [Patch ARM] Fix PR target/50106

2011-10-20 Thread Jakub Jelinek
On Wed, Oct 19, 2011 at 08:27:26PM +0100, Ramana Radhakrishnan wrote: > Ok to backport to 4.6 branch given it is branch freeze time ? I'll be Yeah (with the changes Nathan suggested). > 2011-10-19 Ramana Radhakrishnan > > PR target/50106 > * config/arm/arm.c (thumb_unexpanded_

Re: [Patch ARM] Fix PR target/50106

2011-10-20 Thread Ramana Radhakrishnan
On 19 October 2011 20:38, Nathan Froyd wrote: > On 10/19/2011 3:27 PM, Ramana Radhakrishnan wrote: >> >> Index: gcc/config/arm/arm.c >> -      live_regs_mask |= extra_mask<<  (size / UNITS_PER_WORD); >> +      live_regs_mask |= extra_mask<<  ((size + 3) / UNITS_PER_WORD); > > IIUC, wouldn't ((size

Re: [Patch ARM] Fix PR target/50106

2011-10-19 Thread Nathan Froyd
On 10/19/2011 3:27 PM, Ramana Radhakrishnan wrote: Index: gcc/config/arm/arm.c - live_regs_mask |= extra_mask<< (size / UNITS_PER_WORD); + live_regs_mask |= extra_mask<< ((size + 3) / UNITS_PER_WORD); IIUC, wouldn't ((size + UNITS_PER_WORD - 1) / UNITS_PER_WORD) be clearer? -Nathan

[Patch ARM] Fix PR target/50106

2011-10-19 Thread Ramana Radhakrishnan
Hi, This fixes PR target/50106 which was missing handling return register size from 1-3 for Thumb1. Fixed thusly. Final testing on-going with arm-linux-gnueabi with thumb1. Ok to backport to 4.6 branch given it is branch freeze time ? I'll be able to commit this to the branch latest by tomorrow A