Re: [Patch 2/3] ARM 64 bit atomic operations

2011-07-04 Thread David Gilbert
On 1 July 2011 20:38, Joseph S. Myers wrote: Hi Joseph, Thanks for your comments. > On Fri, 1 Jul 2011, Dr. David Alan Gilbert wrote: > >> +/* For write */ >> +#include >> +/* For abort */ >> +#include > > Please don't include system headers in libgcc without appropriate > inhibit_libc check

Re: [Patch 2/3] ARM 64 bit atomic operations

2011-07-01 Thread Joseph S. Myers
On Fri, 1 Jul 2011, Dr. David Alan Gilbert wrote: > +/* For write */ > +#include > +/* For abort */ > +#include Please don't include system headers in libgcc without appropriate inhibit_libc checks for bootstrap purposes. In this case, it would seem better just to declare the functions you n

Re: [Patch 2/3] ARM 64 bit atomic operations

2011-07-01 Thread David Gilbert
On 1 July 2011 17:03, Richard Henderson wrote: > On 07/01/2011 08:55 AM, Dr. David Alan Gilbert wrote: >> +/* Check that the kernel has a new enough version at load */ >> +void __check_for_sync8_kernelhelper (void) >> +{ >> +  if (__kernel_helper_version < 5) >> +    { >> +      const char err[] =

Re: [Patch 2/3] ARM 64 bit atomic operations

2011-07-01 Thread Richard Henderson
On 07/01/2011 08:55 AM, Dr. David Alan Gilbert wrote: > +/* Check that the kernel has a new enough version at load */ > +void __check_for_sync8_kernelhelper (void) > +{ > + if (__kernel_helper_version < 5) > +{ > + const char err[] = "A newer kernel is required to run this binary. > (__k

[Patch 2/3] ARM 64 bit atomic operations

2011-07-01 Thread Dr. David Alan Gilbert
Provide fallbacks for 64bit atomics that call Linux commpage helpers when compiling for older machines. The code is based on the existing linux-atomic.c for other sizes, however it performs an init time check that the kernel is new enough to provide the helper. This relies on Nicolas P